Issue 12220110: Set the device scale factor from the compositor interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12220110: Set the device scale factor from the compositor interface (Closed)

Created:
7 years, 10 months ago by Jerome

Modified:
7 years, 10 months ago

Reviewers:
Ted C, aelias_OOO_until_Jul13

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Set the device scale factor from the compositor interface Android browser compositor does not have access directly to the LayerTreeHost, only the compositor. This CL allows to set the device scale factor from the compositor interface. BUG=175589 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182171

Patch Set 1 #

Patch Set 2 : More consistent function ordering #

Total comments: 1

Patch Set 3 : dp -> DIP #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
M	content/browser/renderer_host/compositor_impl_android.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/compositor_impl_android.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/public/browser/android/compositor.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

aelias_OOO_until_Jul13

lgtm https://codereview.chromium.org/12220110/diff/2001/content/public/browser/android/compositor.h File content/public/browser/android/compositor.h (right): https://codereview.chromium.org/12220110/diff/2001/content/public/browser/android/compositor.h#newcode63 content/public/browser/android/compositor.h:63: // Set the scale factor from dp to ...

7 years, 10 months ago (2013-02-12 00:16:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jscholler@chromium.org/12220110/6001

7 years, 10 months ago (2013-02-13 01:41:21 UTC) #4

Message was sent while issue was closed.

Change committed as 182171

Expand Messages | Collapse Messages