net/base/cert_database_openssl.cc - Issue 12220104: Wire up SSL client authentication for OpenSSL/Android through the net/ stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/cert_database_openssl.cc

Issue 12220104: Wire up SSL client authentication for OpenSSL/Android through the net/ stack (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: address recent nits Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/cert_database_openssl.cc

diff --git a/net/base/cert_database_openssl.cc b/net/base/cert_database_openssl.cc

index 47effe2876475f4c9c285f5d49a94d6061dbb60c..2a3a4318fd6d183117cce1c32453897377c606d2 100644

--- a/net/base/cert_database_openssl.cc

+++ b/net/base/cert_database_openssl.cc

@@ -27,8 +27,9 @@ int CertDatabase::CheckUserCert(X509Certificate* cert) {

if (cert->HasExpired())

return ERR_CERT_DATE_INVALID;

- if (!OpenSSLPrivateKeyStore::GetInstance()->FetchPrivateKey(

- X509_PUBKEY_get(X509_get_X509_PUBKEY(cert->os_cert_handle()))))

+ OpenSSLPrivateKeyStore::ScopedEVP_PKEY private_key;

+ if (!OpenSSLPrivateKeyStore::GetInstance()->FetchClientCertPrivateKey(

+ cert, &private_key))

Ryan Sleevi 2013/02/14 07:54:01 Braces

digit1 2013/02/25 14:26:22 Done.

return ERR_NO_PRIVATE_KEY_FOR_CERT;

return OK;

« no previous file with comments | « no previous file | net/base/keygen_handler_openssl.cc » ('j') | net/base/openssl_memory_private_key_store.cc » ('J')