Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: content/public/browser/notification_types.h

Issue 12220100: Revert "content: convert SSL notifications to observer usage" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/notification_types.h
diff --git a/content/public/browser/notification_types.h b/content/public/browser/notification_types.h
index cfaafd53610fcefb0312b8fed4278e7c0864a724..4c3bd7153e5722169a89ea6c6835aeb6993d8bb6 100644
--- a/content/public/browser/notification_types.h
+++ b/content/public/browser/notification_types.h
@@ -102,6 +102,40 @@ enum NotificationType {
// issued. Details in the form of a ResourceRedirectDetails are provided.
NOTIFICATION_RESOURCE_RECEIVED_REDIRECT,
+ // SSL ---------------------------------------------------------------------
+
+ // Updating the SSL security indicators (the lock icon and such) proceeds
+ // in two phases:
+ //
+ // 1) The internal SSL state for a host or tab changes. When this happens,
+ // the SSLManager broadcasts an SSL_INTERNAL_STATE_CHANGED notification.
+ //
+ // 2) The SSLManager for each tab receives this notification and might or
+ // might not update the navigation entry for its tab, depending on
+ // whether the change in state affects that tab. If the SSLManager does
+ // change the navigation entry, then the SSLManager broadcasts an
+ // SSL_VISIBLE_STATE_CHANGED notification to the user interface can
+ // redraw properly.
+
+ // The SSL state of a page has changed in some visible way. For example,
+ // if an insecure resource is loaded on a secure page. Note that a
+ // toplevel load commit will also update the SSL state (since the
+ // NavigationEntry is new) and this message won't always be sent in that
+ // case. Listen to this notification if you need to refresh SSL-related UI
+ // elements.
+ //
+ // There is no source or details.
+ NOTIFICATION_SSL_VISIBLE_STATE_CHANGED,
+
+ // The SSL state of the browser has changed in some internal way. For
+ // example, the user might have explicitly allowed some broken certificate
+ // or a secure origin might have included some insecure content. Listen to
+ // this notifiation if you need to keep track of our internal SSL state.
+ //
+ // The source will be the browser context. The details will be the navigation
+ // controller associated with the state change.
+ NOTIFICATION_SSL_INTERNAL_STATE_CHANGED,
+
// Devtools ------------------------------------------------------------------
// Indicates that a devtools agent has attached to a client. The source is
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698