Issue 12220100: Revert "content: convert SSL notifications to observer usage"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12220100: Revert "content: convert SSL notifications to observer usage" (Closed)

Created:
7 years, 10 months ago by Paweł Hajdan Jr.

Modified:
7 years, 10 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert "content: convert SSL notifications to observer usage" Caused new crashes. TBR=jam BUG=175308, 170921 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181738

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -108 lines)			Patch
M	chrome/browser/ssl/ssl_blocking_page.cc	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/ssl/ssl_tab_helper.h	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/ssl/ssl_tab_helper.cc	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	chrome/browser/ui/browser.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	3 chunks	+15 lines, -8 lines	0 comments	Download
M	content/browser/ssl/ssl_manager.h	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	content/browser/ssl/ssl_manager.cc	View	9 chunks	+27 lines, -54 lines	0 comments	Download
M	content/browser/ssl/ssl_policy_backend.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	3 chunks	+2 lines, -9 lines	0 comments	Download
M	content/public/browser/notification_types.h	View	1 chunk	+34 lines, -0 lines	0 comments	Download
M	content/public/browser/web_contents_observer.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 1 (0 generated)

Message was sent while issue was closed.

TBR