Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: tools/dom/scripts/htmlrenamer.py

Issue 12220099: Remove Webkit prefix from all members and make experimental. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/dom/scripts/generator.py ('k') | tools/dom/scripts/systemhtml.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 2 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
3 # for details. All rights reserved. Use of this source code is governed by a 3 # for details. All rights reserved. Use of this source code is governed by a
4 # BSD-style license that can be found in the LICENSE file. 4 # BSD-style license that can be found in the LICENSE file.
5 import logging 5 import logging
6 import monitored 6 import monitored
7 import re 7 import re
8 8
9 html_interface_renames = monitored.Dict('htmlrenamer.html_interface_renames', { 9 html_interface_renames = monitored.Dict('htmlrenamer.html_interface_renames', {
10 'CDATASection': 'CDataSection', 10 'CDATASection': 'CDataSection',
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 'UIEvent.initUIEvent', 173 'UIEvent.initUIEvent',
174 'UIEvent.keyCode', 174 'UIEvent.keyCode',
175 'WheelEvent.wheelDeltaX', 175 'WheelEvent.wheelDeltaX',
176 'WheelEvent.wheelDeltaY', 176 'WheelEvent.wheelDeltaY',
177 'WheelEvent.initWebKitWheelEvent', 177 'WheelEvent.initWebKitWheelEvent',
178 'DOMWindow.getComputedStyle', 178 'DOMWindow.getComputedStyle',
179 ]) 179 ])
180 180
181 # Members from the standard dom that exist in the dart:html library with 181 # Members from the standard dom that exist in the dart:html library with
182 # identical functionality but with cleaner names. 182 # identical functionality but with cleaner names.
183 _renamed_html_members = monitored.Dict('htmlrenamer._renamed_html_members', { 183 renamed_html_members = monitored.Dict('htmlrenamer.renamed_html_members', {
184 'Document.createCDATASection': 'createCDataSection',
185 'Document.defaultView': 'window',
184 'DOMURL.createObjectURL': 'createObjectUrl', 186 'DOMURL.createObjectURL': 'createObjectUrl',
185 'DOMURL.revokeObjectURL': 'revokeObjectUrl', 187 'DOMURL.revokeObjectURL': 'revokeObjectUrl',
186 'DOMWindow.webkitConvertPointFromNodeToPage': 'convertPointFromNodeToPage', 188 'DOMWindow.webkitConvertPointFromNodeToPage': 'convertPointFromNodeToPage',
187 'DOMWindow.webkitConvertPointFromPageToNode': 'convertPointFromPageToNode', 189 'DOMWindow.webkitConvertPointFromPageToNode': 'convertPointFromPageToNode',
188 'DOMWindow.webkitNotifications': 'notifications', 190 'DOMWindow.webkitNotifications': 'notifications',
189 'DOMWindow.webkitRequestFileSystem': 'requestFileSystem', 191 'DOMWindow.webkitRequestFileSystem': 'requestFileSystem',
190 'DOMWindow.webkitResolveLocalFileSystemURL': 'resolveLocalFileSystemUrl', 192 'DOMWindow.webkitResolveLocalFileSystemURL': 'resolveLocalFileSystemUrl',
191 'DOMWindow.webkitRequestFileSystem': 'requestFileSystem', 193 'DOMWindow.webkitRequestFileSystem': 'requestFileSystem',
192 'DOMWindow.webkitResolveLocalFileSystemURL': 'resolveLocalFileSystemUrl', 194 'DOMWindow.webkitResolveLocalFileSystemURL': 'resolveLocalFileSystemUrl',
193 'Document.createCDATASection': 'createCDataSection',
194 'Document.defaultView': 'window',
195 'Element.scrollIntoViewIfNeeded': 'scrollIntoView', 195 'Element.scrollIntoViewIfNeeded': 'scrollIntoView',
196 'Element.webkitCreateShadowRoot': 'createShadowRoot', 196 'Element.webkitCreateShadowRoot': 'createShadowRoot',
197 'Element.webkitMatchesSelector' : 'matches', 197 'Element.webkitMatchesSelector' : 'matches',
198 'Navigator.webkitGetUserMedia': '_getUserMedia', 198 'Navigator.webkitGetUserMedia': '_getUserMedia',
199 'Node.cloneNode': 'clone', 199 'Node.cloneNode': 'clone',
200 'Node.nextSibling': 'nextNode', 200 'Node.nextSibling': 'nextNode',
201 'Node.ownerDocument': 'document', 201 'Node.ownerDocument': 'document',
202 'Node.parentElement': 'parent', 202 'Node.parentElement': 'parent',
203 'Node.previousSibling': 'previousNode', 203 'Node.previousSibling': 'previousNode',
204 'Node.textContent': 'text', 204 'Node.textContent': 'text',
(...skipping 19 matching lines...) Expand all
224 'CanvasRenderingContext2D.drawImageFromRect', 224 'CanvasRenderingContext2D.drawImageFromRect',
225 'CanvasRenderingContext2D.setAlpha', 225 'CanvasRenderingContext2D.setAlpha',
226 'CanvasRenderingContext2D.setCompositeOperation', 226 'CanvasRenderingContext2D.setCompositeOperation',
227 'CanvasRenderingContext2D.setFillColor', 227 'CanvasRenderingContext2D.setFillColor',
228 'CanvasRenderingContext2D.setLineCap', 228 'CanvasRenderingContext2D.setLineCap',
229 'CanvasRenderingContext2D.setLineJoin', 229 'CanvasRenderingContext2D.setLineJoin',
230 'CanvasRenderingContext2D.setLineWidth', 230 'CanvasRenderingContext2D.setLineWidth',
231 'CanvasRenderingContext2D.setMiterLimit', 231 'CanvasRenderingContext2D.setMiterLimit',
232 'CanvasRenderingContext2D.setShadow', 232 'CanvasRenderingContext2D.setShadow',
233 'CanvasRenderingContext2D.setStrokeColor', 233 'CanvasRenderingContext2D.setStrokeColor',
234 'CanvasRenderingContext2D.webkitLineDashOffset',
234 'CharacterData.remove', 235 'CharacterData.remove',
235 'DOMWindow.call:blur', 236 'DOMWindow.call:blur',
236 'DOMWindow.clientInformation', 237 'DOMWindow.clientInformation',
237 'DOMWindow.call:focus', 238 'DOMWindow.call:focus',
238 'DOMWindow.get:frames', 239 'DOMWindow.get:frames',
239 'DOMWindow.get:length', 240 'DOMWindow.get:length',
240 'DOMWindow.prompt', 241 'DOMWindow.prompt',
242 'DOMWindow.webkitCancelAnimationFrame',
241 'DOMWindow.webkitCancelRequestAnimationFrame', 243 'DOMWindow.webkitCancelRequestAnimationFrame',
242 'DOMWindow.webkitIndexedDB', 244 'DOMWindow.webkitIndexedDB',
245 'DOMWindow.webkitRequestAnimationFrame',
243 'Document.adoptNode', 246 'Document.adoptNode',
244 'Document.alinkColor', 247 'Document.alinkColor',
245 'Document.all', 248 'Document.all',
246 'Document.applets', 249 'Document.applets',
247 'Document.bgColor', 250 'Document.bgColor',
248 'Document.captureEvents', 251 'Document.captureEvents',
249 'Document.clear', 252 'Document.clear',
250 'Document.createAttribute', 253 'Document.createAttribute',
251 'Document.createAttributeNS', 254 'Document.createAttributeNS',
252 'Document.createComment', 255 'Document.createComment',
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
505 """ 508 """
506 interface = self._database.GetInterface(interface_name) 509 interface = self._database.GetInterface(interface_name)
507 510
508 if self.ShouldSuppressMember(interface, member, member_prefix): 511 if self.ShouldSuppressMember(interface, member, member_prefix):
509 return None 512 return None
510 513
511 if 'CheckSecurityForNode' in member_node.ext_attrs: 514 if 'CheckSecurityForNode' in member_node.ext_attrs:
512 return None 515 return None
513 516
514 name = self._FindMatch(interface, member, member_prefix, 517 name = self._FindMatch(interface, member, member_prefix,
515 _renamed_html_members) 518 renamed_html_members)
516 519
517 target_name = _renamed_html_members[name] if name else member 520 target_name = renamed_html_members[name] if name else member
518 if self._FindMatch(interface, member, member_prefix, _private_html_members): 521 if self._FindMatch(interface, member, member_prefix, _private_html_members):
519 if not target_name.startswith('$dom_'): # e.g. $dom_svgClassName 522 if not target_name.startswith('$dom_'): # e.g. $dom_svgClassName
520 target_name = '$dom_' + target_name 523 target_name = '$dom_' + target_name
521 524
525 if not name and target_name.startswith('webkit'):
526 target_name = member[len('webkit'):]
527 target_name = target_name[:1].lower() + target_name[1:]
528
522 if dartify_name: 529 if dartify_name:
523 target_name = self._DartifyMemberName(target_name) 530 target_name = self._DartifyMemberName(target_name)
524 return target_name 531 return target_name
525 532
526 def ShouldSuppressMember(self, interface, member, member_prefix=''): 533 def ShouldSuppressMember(self, interface, member, member_prefix=''):
527 """ Returns true if the member should be suppressed.""" 534 """ Returns true if the member should be suppressed."""
528 if self._FindMatch(interface, member, member_prefix, 535 if self._FindMatch(interface, member, member_prefix,
529 _removed_html_members): 536 _removed_html_members):
530 return True 537 return True
531 return False 538 return False
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
577 584
578 # We're looking for a sequence of letters which start with capital letter 585 # We're looking for a sequence of letters which start with capital letter
579 # then a series of caps and finishes with either the end of the string or 586 # then a series of caps and finishes with either the end of the string or
580 # a capital letter. 587 # a capital letter.
581 # The [0-9] check is for names such as 2D or 3D 588 # The [0-9] check is for names such as 2D or 3D
582 # The following test cases should match as: 589 # The following test cases should match as:
583 # WebKitCSSFilterValue: WebKit(C)(SS)(F)ilterValue 590 # WebKitCSSFilterValue: WebKit(C)(SS)(F)ilterValue
584 # XPathNSResolver: (X)()(P)ath(N)(S)(R)esolver (no change) 591 # XPathNSResolver: (X)()(P)ath(N)(S)(R)esolver (no change)
585 # IFrameElement: (I)()(F)rameElement (no change) 592 # IFrameElement: (I)()(F)rameElement (no change)
586 return re.sub(r'([A-Z])([A-Z]{2,})([A-Z]|$)', toLower, name) 593 return re.sub(r'([A-Z])([A-Z]{2,})([A-Z]|$)', toLower, name)
OLDNEW
« no previous file with comments | « tools/dom/scripts/generator.py ('k') | tools/dom/scripts/systemhtml.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698