Add implementations of WebKit::Platform testing APIs to TestWebKitPlatformSupport

Add implementations of WebKit::Platform testing APIs to TestWebKitPlatformSupport

This enables running nearly all webkit_unit_tests (in conjunction with https://bugs.webkit.org/show_bug.cgi?id=109369).

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181645

[darin (slow to review), 2013-02-10 05:07:03]

https://codereview.chromium.org/12220091/diff/1/webkit/support/test_webkit_pl...
File webkit/support/test_webkit_platform_support.cc (right):

https://codereview.chromium.org/12220091/diff/1/webkit/support/test_webkit_pl...
webkit/support/test_webkit_platform_support.cc:641: WebKit::WebString
TestWebKitPlatformSupport::getWebKitRootDir() {
this looks like a copy of GetWebKitRootDirFilePath.  is there a way to avoid
duplicating that code?

https://codereview.chromium.org/12220091/diff/1/webkit/support/test_webkit_pl...
File webkit/support/test_webkit_platform_support.h (right):

https://codereview.chromium.org/12220091/diff/1/webkit/support/test_webkit_pl...
webkit/support/test_webkit_platform_support.h:158: virtual WebKit::WebString
getWebKitRootDir();
nit: in the WebKit API, methods like this often lack the "get" prefix.

[jamesr, 2013-02-10 06:05:30]

On 2013/02/10 05:07:03, darin wrote:
>
https://codereview.chromium.org/12220091/diff/1/webkit/support/test_webkit_pl...
> File webkit/support/test_webkit_platform_support.cc (right):
> 
>
https://codereview.chromium.org/12220091/diff/1/webkit/support/test_webkit_pl...
> webkit/support/test_webkit_platform_support.cc:641: WebKit::WebString
> TestWebKitPlatformSupport::getWebKitRootDir() {
> this looks like a copy of GetWebKitRootDirFilePath.  is there a way to avoid
> duplicating that code?
> 

changed to just call webkit_support::GetWebKitRootDir()

>
https://codereview.chromium.org/12220091/diff/1/webkit/support/test_webkit_pl...
> File webkit/support/test_webkit_platform_support.h (right):
> 
>
https://codereview.chromium.org/12220091/diff/1/webkit/support/test_webkit_pl...
> webkit/support/test_webkit_platform_support.h:158: virtual WebKit::WebString
> getWebKitRootDir();
> nit: in the WebKit API, methods like this often lack the "get" prefix.

renamed

[darin (slow to review), 2013-02-10 06:07:17]

LGTM

[commit-bot: I haz the power, 2013-02-10 07:26:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/12220091/8002

[commit-bot: I haz the power, 2013-02-10 12:42:28]

Change committed as 181645