native_client_sdk/src/tools/common.mk - Issue 12220085: [NaCl SDK] Print nice error if host build can't find gcc or cl.exe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/tools/common.mk

Issue 12220085: [NaCl SDK] Print nice error if host build can't find gcc or cl.exe (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/tools/common.mk

diff --git a/native_client_sdk/src/tools/common.mk b/native_client_sdk/src/tools/common.mk

index 1a340fb72bf38ed3e896ad6bca33184461e90df8..ba6ff0f60c698beea5117c7da9cbeb7735f2846d 100644

--- a/native_client_sdk/src/tools/common.mk

+++ b/native_client_sdk/src/tools/common.mk

@@ -69,6 +69,7 @@ CP:=python $(NACL_SDK_ROOT)/tools/oshelpers.py cp

MKDIR:=python $(NACL_SDK_ROOT)/tools/oshelpers.py mkdir

MV:=python $(NACL_SDK_ROOT)/tools/oshelpers.py mv

RM:=python $(NACL_SDK_ROOT)/tools/oshelpers.py rm

+WHICH:=python $(NACL_SDK_ROOT)/tools/oshelpers.py which

@@ -196,7 +197,11 @@ include $(NACL_SDK_ROOT)/tools/host_gcc.mk

endif

ifneq (,$(findstring $(TOOLCHAIN),win))

+ifneq (,$(findstring $(shell $(WHICH) cl.exe),cl.exe))

noelallen1 2013/02/08 23:50:06 nit: I would have put the WIN specific stuff in h

include $(NACL_SDK_ROOT)/tools/host_vc.mk

+else

+$(warning cl.exe not found in PATH. Skipping host build.)

+endif

endif

ifneq (,$(findstring $(TOOLCHAIN),glibc newlib))

« no previous file with comments | « no previous file | native_client_sdk/src/tools/oshelpers.py » ('j') | no next file with comments »