[NaCl SDK] Print nice error if host build can't find gcc or cl.exe

[NaCl SDK] Print nice error if host build can't find gcc or cl.exe

Previously, the build would fail with when at compile time.

BUG=none
R=noelallen@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181725

[noelallen1, 2013-02-08 23:50:06]

lgtm

LGTM

https://codereview.chromium.org/12220085/diff/1/native_client_sdk/src/tools/c...
File native_client_sdk/src/tools/common.mk (right):

https://codereview.chromium.org/12220085/diff/1/native_client_sdk/src/tools/c...
native_client_sdk/src/tools/common.mk:200: ifneq (,$(findstring $(shell $(WHICH)
cl.exe),cl.exe))
nit:  I would have put the WIN specific stuff in host_vc as much as possible.

[binji, 2013-02-09 00:52:39]

PTAL

Filtering out when building all_versions as we discussed.

[noelallen_use_chromium, 2013-02-09 00:55:57]

https://codereview.chromium.org/12220085/diff/7001/native_client_sdk/src/tool...
File native_client_sdk/src/tools/common.mk (right):

https://codereview.chromium.org/12220085/diff/7001/native_client_sdk/src/tool...
native_client_sdk/src/tools/common.mk:113: USABLE_TOOLCHAINS:=$(filter-out
$(OSNAME),$(USABLE_TOOLCHAINS))
$(warning Skipping host builds)

https://codereview.chromium.org/12220085/diff/7001/native_client_sdk/src/tool...
native_client_sdk/src/tools/common.mk:124: endif
Won't this generate an empty target warning/error for non windows?

[binji, 2013-02-09 01:12:54]

PTAL

[Sam Clegg, 2013-02-09 01:28:14]

https://codereview.chromium.org/12220085/diff/9001/native_client_sdk/src/tool...
File native_client_sdk/src/tools/oshelpers.py (right):

https://codereview.chromium.org/12220085/diff/9001/native_client_sdk/src/tool...
native_client_sdk/src/tools/oshelpers.py:483: if files == 0:
if not files:

https://codereview.chromium.org/12220085/diff/9001/native_client_sdk/src/tool...
native_client_sdk/src/tools/oshelpers.py:484: return
parser.error("no files specified")?

No need for return if you do this.

https://codereview.chromium.org/12220085/diff/9001/native_client_sdk/src/tool...
native_client_sdk/src/tools/oshelpers.py:502: print
os.path.abspath(os.path.join(path, filename))
Might want to also append try adding .com .bat and .exe if running on windows?

[binji, 2013-02-09 01:44:42]

https://codereview.chromium.org/12220085/diff/9001/native_client_sdk/src/tool...
File native_client_sdk/src/tools/oshelpers.py (right):

https://codereview.chromium.org/12220085/diff/9001/native_client_sdk/src/tool...
native_client_sdk/src/tools/oshelpers.py:483: if files == 0:
On 2013/02/09 01:28:14, Sam Clegg wrote:
> if not files:

Done. Whoops.

https://codereview.chromium.org/12220085/diff/9001/native_client_sdk/src/tool...
native_client_sdk/src/tools/oshelpers.py:484: return
On 2013/02/09 01:28:14, Sam Clegg wrote:
> parser.error("no files specified")?
> 
> No need for return if you do this.

It's not an error to run which without arguments.

https://codereview.chromium.org/12220085/diff/9001/native_client_sdk/src/tool...
native_client_sdk/src/tools/oshelpers.py:502: print
os.path.abspath(os.path.join(path, filename))
On 2013/02/09 01:28:14, Sam Clegg wrote:
> Might want to also append try adding .com .bat and .exe if running on windows?

Not needed in this CL, we can add it later if desired.

[Sam Clegg, 2013-02-09 01:49:28]

https://codereview.chromium.org/12220085/diff/9001/native_client_sdk/src/tool...
File native_client_sdk/src/tools/oshelpers.py (right):

https://codereview.chromium.org/12220085/diff/9001/native_client_sdk/src/tool...
native_client_sdk/src/tools/oshelpers.py:484: return
On 2013/02/09 01:44:43, binji wrote:
> On 2013/02/09 01:28:14, Sam Clegg wrote:
> > parser.error("no files specified")?
> > 
> > No need for return if you do this.
> 
> It's not an error to run which without arguments.

Ha!  At least it should return non-zero here then.

[Sam Clegg, 2013-02-09 01:49:37]

lgtm

[noelallen_use_chromium, 2013-02-09 01:58:01]

lgtm

[binji, 2013-02-09 02:31:44]

https://codereview.chromium.org/12220085/diff/9001/native_client_sdk/src/tool...
File native_client_sdk/src/tools/oshelpers.py (right):

https://codereview.chromium.org/12220085/diff/9001/native_client_sdk/src/tool...
native_client_sdk/src/tools/oshelpers.py:484: return
On 2013/02/09 01:49:28, Sam Clegg wrote:
> On 2013/02/09 01:44:43, binji wrote:
> > On 2013/02/09 01:28:14, Sam Clegg wrote:
> > > parser.error("no files specified")?
> > > 
> > > No need for return if you do this.
> > 
> > It's not an error to run which without arguments.
> 
> Ha!  At least it should return non-zero here then.

Done.

[commit-bot: I haz the power, 2013-02-09 03:21:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/12220085/13001

[commit-bot: I haz the power, 2013-02-09 03:21:58]

Presubmit check for 12220085-13001 failed and returned exit status 1.

INFO:root:Found 5 file(s).

INFO:PRESUBMIT:Running pylint on: ['PRESUBMIT.py', 'src/test_all.py',
'src/project_templates/init_project_test.py',
'src/project_templates/init_project.py', 'src/build_tools/generate_notice.py',
'src/build_tools/update_sdktools.py', 'src/build_tools/test_sdk.py',
'src/build_tools/buildbot_run.py', 'src/build_tools/update_nacl_manifest.py',
'src/build_tools/nacl-mono-buildbot.py', 'src/build_tools/manifest_util.py',
'src/build_tools/make_rules.py', 'src/build_tools/__init__.py',
'src/build_tools/generate_index.py', 'src/build_tools/build_updater.py',
'src/build_tools/build_examples.py', 'src/build_tools/dsc2gyp.py',
'src/build_tools/nacl-mono-builder.py', 'src/build_tools/build_utils.py',
'src/build_tools/nacl-mono-archive.py', 'src/build_tools/generate_make.py',
'src/build_tools/make_simple.py', 'src/build_tools/buildbot_common.py',
'src/build_tools/build_sdk.py', 'src/build_tools/sdk_tools/set_nacl_env.py',
'src/build_tools/sdk_tools/config.py', 'src/build_tools/sdk_tools/__init__.py',
'src/build_tools/sdk_tools/sdk_update.py',
'src/build_tools/sdk_tools/sdk_update_main.py',
'src/build_tools/sdk_tools/sdk_update_common.py',
'src/build_tools/sdk_tools/download.py',
'src/build_tools/sdk_tools/command/info.py',
'src/build_tools/sdk_tools/command/sources.py',
'src/build_tools/sdk_tools/command/__init__.py',
'src/build_tools/sdk_tools/command/update.py',
'src/build_tools/sdk_tools/command/list.py',
'src/examples/debugging/handler.py', 'src/tools/decode_dump.py',
'src/tools/getos.py', 'src/tools/oshelpers.py', 'src/tools/compiler-wrapper.py',
'src/tools/genhttpfs.py', 'src/tools/quote.py', 'src/tools/quote_test.py',
'src/tools/run.py', 'src/tools/httpd.py', 'src/tools/create_nmf.py',
'src/tools/tests/httpd_test.py', 'src/tools/tests/chrome_mock.py',
'src/tools/tests/oshelpers_test.py', 'src/tools/tests/create_nmf_test.py']
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/native_client_sdk/PRESUBMIT.py
Running pylint on 51 files.

** Presubmit ERRORS **
Run the command: svn pset svn:eol-style LF \
  native_client_sdk/src/tools/common.mk \
  native_client_sdk/src/tools/host_gcc.mk \
  native_client_sdk/src/tools/host_vc.mk

Presubmit checks took 7.2s to calculate.