Split queue into metadata and file data queues

Split queue into metadata and file data queues
Allow downloading of metadata even if drive is disabled on LTE

BUG=175068
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181843

[Zachary Kuznia, 2013-02-08 08:23:53]

Please Take a look

Thanks,
-Zach

[kinaba, 2013-02-12 01:49:48]

I'm still unsure whether it is good to have FILE_QUEUE+BACKGROUND and
FILE_QUEUE+USER_INITIATED lives in a same queue (= background sync blocks
double-click file open until one file finishes syncing), but perhaps we can
think about it later. LGTM with nits for M26.

https://codereview.chromium.org/12220073/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/drive_scheduler.cc (right):

https://codereview.chromium.org/12220073/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_scheduler.cc:26: 
nit:

https://codereview.chromium.org/12220073/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_scheduler.cc:483: DriveClientContext&
context) {
const DriveClientContext&

https://codereview.chromium.org/12220073/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_scheduler.cc:703: for (QueueType i =
METADATA_QUEUE; i < NUM_QUEUES; ++i) {
Does it compile (I mean, increment for enums)?
I guess we'd better avoid it and use static_cast from int.

https://codereview.chromium.org/12220073/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/drive_scheduler.h (right):

https://codereview.chromium.org/12220073/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_scheduler.h:291: bool
ShouldStopJobLoop(QueueType queue_type, DriveClientContext& context);
const DriveClientContext&

[Zachary Kuznia, 2013-02-12 02:28:47]

https://codereview.chromium.org/12220073/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/drive_scheduler.cc (right):

https://codereview.chromium.org/12220073/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_scheduler.cc:26: 
On 2013/02/12 01:49:48, kinaba wrote:
> nit:

Done.

https://codereview.chromium.org/12220073/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_scheduler.cc:483: DriveClientContext&
context) {
On 2013/02/12 01:49:48, kinaba wrote:
> const DriveClientContext&

Done.

https://codereview.chromium.org/12220073/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_scheduler.cc:703: for (QueueType i =
METADATA_QUEUE; i < NUM_QUEUES; ++i) {
On 2013/02/12 01:49:48, kinaba wrote:
> Does it compile (I mean, increment for enums)?
> I guess we'd better avoid it and use static_cast from int.

Done.

https://codereview.chromium.org/12220073/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/drive_scheduler.h (right):

https://codereview.chromium.org/12220073/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_scheduler.h:291: bool
ShouldStopJobLoop(QueueType queue_type, DriveClientContext& context);
On 2013/02/12 01:49:48, kinaba wrote:
> const DriveClientContext&

Done.

[commit-bot: I haz the power, 2013-02-12 02:29:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/12220073/6001

[commit-bot: I haz the power, 2013-02-12 03:50:11]

Retried try job too often on mac_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-02-12 03:59:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/12220073/6001