Shill: ShillServiceClient destroys ShillClientHelpers when they are not need.

chromeos/dbus/shill_client_helper.h

Index: chromeos/dbus/shill_client_helper.h
diff --git a/chromeos/dbus/shill_client_helper.h b/chromeos/dbus/shill_client_helper.h
index b8f769c4fcf76dc0aaeb848b6584b78c7c875d72..d03b74b225d780149410fff1a2280511c650c743 100644
--- a/chromeos/dbus/shill_client_helper.h
+++ b/chromeos/dbus/shill_client_helper.h
@@ -66,6 +66,15 @@ class ShillClientHelper {
 
   virtual ~ShillClientHelper();
 
+  // Returns whether there is an observed registered for the PropertyChange or
+  // not.

[stevenjb, 2013/02/06 01:05:53]

nit: // Returns true if there is a PropertyChangedObserver registered
(see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...)

[deymo, 2013/02/06 05:44:45]

Done.

+  bool IsObserved() const;
+
+  // Returns true if the are method calls waiting for a response. In addition,
+  // if this function is called from within the return callback and there are
+  // not *other* calls waiting for a response, this function returns false.

[stevenjb, 2013/02/06 01:05:53]

// Returns true if there are method calls waiting for a response. If this
function is called from within the return callback returns true only if there
are *other* calls waiting for a response.
(Don't combine 'returns true' and 'returns false', it's challenging to parse)

[deymo, 2013/02/06 05:44:45]

Done.

+  bool IsWaitingResponse() const;
+
   // Adds an |observer| of the PropertyChanged signal.
   void AddPropertyChangedObserver(ShillPropertyChangedObserver* observer);
 
@@ -180,6 +189,7 @@ class ShillClientHelper {
   PropertyChangedHandler property_changed_handler_;
   ObserverList<ShillPropertyChangedObserver, true /* check_empty */>
       observer_list_;
+  int ongoing_calls;

[stevenjb, 2013/02/06 01:05:53]

Missing trailing _
Also, maybe use pending_calls_

[deymo, 2013/02/06 05:44:45]

More than "pending_calls" is pending "returns". The "call" part is already done.
unreturned_calls_ ?

[stevenjb, 2013/02/06 17:10:20]

nit: Hm, 'unreturned' works, but sounds a bit awkward. 'in_progress_calls'? Or
'pending_callbacks'? 

 
   // Note: This should remain the last member so it'll be destroyed and
   // invalidate its weak pointers before any other members are destroyed.