Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1221973002: Check the return value of Platform::current()->currentThread() for media_blink_unittests.

Created:
5 years, 5 months ago by horo
Modified:
5 years, 5 months ago
Reviewers:
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Check the return value of Platform::current()->currentThread() for media_blink_unittests. TestBlinkPlatformSupport class in media/blink/run_all_unittests.cc dosen't implement currentThread(). So BufferedResourceLoaderTest and BufferedDataSourceTest in media_blink_unittests are failing in the constructor of blink::TimerBase. #0 0x0000005e802e base::debug::StackTrace::StackTrace() #1 0x0000005e7b6f base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f9ba8f1d340 <unknown> #3 0x000002f86d28 blink::TimerBase::TimerBase() #4 0x0000010a5db4 blink::Timer<>::Timer() #5 0x0000010a53aa blink::ValidationMessageClientImpl::ValidationMessageClientImpl() #6 0x0000010a56a6 blink::ValidationMessageClientImpl::create() #7 0x000001048049 blink::WebViewImpl::WebViewImpl() #8 0x0000010471bb blink::WebViewImpl::create() #9 0x000001047185 blink::WebView::create() #10 0x00000042726b media::BufferedDataSourceTest::BufferedDataSourceTest() BUG=506122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M Source/platform/Timer.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698