Define default but still private MediaSession constructor

Define default but still private MediaSession constructor

BUG=497735
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198271

[davve, 2015-07-02 14:57:29]

davve@opera.com changed reviewers:
+ avayvod@chromium.org, mlamouri@chromium.org, philipj@opera.com

[whywhat, 2015-07-02 15:05:16]

Note that Chromium's style guide doesn't allow inlining stuff (with small
exceptions):

https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-i....

Not sure if it applies to Blink but probably should :)

https://codereview.chromium.org/1221953003/diff/1/Source/modules/mediasession...
File Source/modules/mediasession/MediaSession.h (right):

https://codereview.chromium.org/1221953003/diff/1/Source/modules/mediasession...
Source/modules/mediasession/MediaSession.h:24: MediaSession() { }
 = default

[davve, 2015-07-02 15:19:53]

https://codereview.chromium.org/1221953003/diff/1/Source/modules/mediasession...
File Source/modules/mediasession/MediaSession.h (right):

https://codereview.chromium.org/1221953003/diff/1/Source/modules/mediasession...
Source/modules/mediasession/MediaSession.h:24: MediaSession() { }
On 2015/07/02 15:05:16, whywhat wrote:
>  = default

https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-i...

was a good read. Thanks!

So you would recommend moving back the implementation to the .cpp file and use
'= default' there?

[whywhat, 2015-07-02 15:33:50]

https://codereview.chromium.org/1221953003/diff/1/Source/modules/mediasession...
File Source/modules/mediasession/MediaSession.h (right):

https://codereview.chromium.org/1221953003/diff/1/Source/modules/mediasession...
Source/modules/mediasession/MediaSession.h:24: MediaSession() { }
On 2015/07/02 at 15:19:53, David Vest wrote:
> On 2015/07/02 15:05:16, whywhat wrote:
> >  = default
> 
>
https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-i...
> 
> was a good read. Thanks!
> 
> So you would recommend moving back the implementation to the .cpp file and use
'= default' there?

As I understand, you either leave it as it was (empty implementation in .cpp
file) or use '= default' in the header which is not the same as inlining so the
forward declaration example would compile.

[mlamouri (slow - plz ping), 2015-07-02 17:28:55]

https://codereview.chromium.org/1221953003/diff/1/Source/modules/mediasession...
File Source/modules/mediasession/MediaSession.h (right):

https://codereview.chromium.org/1221953003/diff/1/Source/modules/mediasession...
Source/modules/mediasession/MediaSession.h:24: MediaSession() { }
On 2015/07/02 at 15:33:50, whywhat wrote:
> On 2015/07/02 at 15:19:53, David Vest wrote:
> > On 2015/07/02 15:05:16, whywhat wrote:
> > >  = default
> > 
> >
https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-i...
> > 
> > was a good read. Thanks!
> > 
> > So you would recommend moving back the implementation to the .cpp file and
use '= default' there?
> 
> As I understand, you either leave it as it was (empty implementation in .cpp
file) or use '= default' in the header which is not the same as inlining so the
forward declaration example would compile.

+1 for using "= default". lgtm with that.

[davve, 2015-07-03 08:33:15]

The CQ bit was checked by davve@opera.com

[davve, 2015-07-03 08:33:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1221953003/#ps20001
(title: "Use '= default'")

[commit-bot: I haz the power, 2015-07-03 08:33:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1221953003/20001

[commit-bot: I haz the power, 2015-07-03 10:18:17]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198271