third_party/polymer/v1_0/components-chromium/iron-range-behavior/iron-range-behavior-extracted.js - Issue 1221923003: Update bower.json for Polymer elements and add PRESUBMIT.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/polymer/v1_0/components-chromium/iron-range-behavior/iron-range-behavior-extracted.js

Issue 1221923003: Update bower.json for Polymer elements and add PRESUBMIT.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/polymer/v1_0/PRESUBMIT.py ('K') | « third_party/polymer/v1_0/components-chromium/iron-range-behavior/index.html ('k') | third_party/polymer/v1_0/components-chromium/iron-resizable-behavior/.bower.json » ('j') | third_party/polymer/v1_0/components/paper-toast/paper-toast.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/polymer/v1_0/components-chromium/iron-range-behavior/iron-range-behavior-extracted.js

diff --git a/third_party/polymer/v1_0/components-chromium/iron-range-behavior/iron-range-behavior-extracted.js b/third_party/polymer/v1_0/components-chromium/iron-range-behavior/iron-range-behavior-extracted.js

index ce733745cafb60ec55844f4bbbcf649ff2e4713e..c16f335fbfacddf73e6764fd62dfd29d305d1587 100644

--- a/third_party/polymer/v1_0/components-chromium/iron-range-behavior/iron-range-behavior-extracted.js

+++ b/third_party/polymer/v1_0/components-chromium/iron-range-behavior/iron-range-behavior-extracted.js

@@ -71,6 +71,14 @@

_calcStep: function(value) {

+ /**

+ * if we calculate the step using

+ * `Math.round(value / step) * step` we may hit a precision point issue

+ * eg. 0.1 * 0.2 = 0.020000000000000004

+ * http://docs.oracle.com/cd/E19957-01/806-3568/ncg_goldberg.html

+ *

+ * as a work around we can divide by the reciprocal of `step`

+ */

return this.step ? (Math.round(value / this.step) / (1 / this.step)) : value;