third_party/polymer/v1_0/components-chromium/iron-pages/iron-pages-extracted.js - Issue 1221923003: Update bower.json for Polymer elements and add PRESUBMIT.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/polymer/v1_0/components-chromium/iron-pages/iron-pages-extracted.js

Issue 1221923003: Update bower.json for Polymer elements and add PRESUBMIT.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/polymer/v1_0/components-chromium/iron-pages/hero.svg ('k') | third_party/polymer/v1_0/components-chromium/iron-range-behavior/.bower.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/polymer/v1_0/components-chromium/iron-pages/iron-pages-extracted.js

diff --git a/third_party/polymer/v1_0/components-chromium/iron-pages/iron-pages-extracted.js b/third_party/polymer/v1_0/components-chromium/iron-pages/iron-pages-extracted.js

index 503d9b5c10c875f47a8bd5bdf2ae315de3cfebb5..c175b14c7f5abe74bc8d591e256e7e03c59096d4 100644

--- a/third_party/polymer/v1_0/components-chromium/iron-pages/iron-pages-extracted.js

+++ b/third_party/polymer/v1_0/components-chromium/iron-pages/iron-pages-extracted.js

@@ -9,6 +9,18 @@

Polymer.IronSelectableBehavior

+ properties: {

+ // as the selected page is the only one visible, activateEvent

+ // is both non-sensical and problematic; e.g. in cases where a user

+ // handler attempts to change the page and the activateEvent

+ // handler immediately changes it back

+ activateEvent: {

+ value: null

+ }

+ },

observers: [

'_selectedPageChanged(selected)'