third_party/polymer/v1_0/components/paper-input/paper-input-error.html - Issue 1221923003: Update bower.json for Polymer elements and add PRESUBMIT.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/polymer/v1_0/components/paper-input/paper-input-error.html

Issue 1221923003: Update bower.json for Polymer elements and add PRESUBMIT.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/polymer/v1_0/components/paper-input/paper-input-container.html ('k') | third_party/polymer/v1_0/components/paper-input/paper-textarea.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/polymer/v1_0/components/paper-input/paper-input-error.html

diff --git a/third_party/polymer/v1_0/components/paper-input/paper-input-error.html b/third_party/polymer/v1_0/components/paper-input/paper-input-error.html

index c034e9624cdc188ee1159a439fcd31cc70063aac..f23c49c1b05a111819447357bb24297ff10953de 100644

--- a/third_party/polymer/v1_0/components/paper-input/paper-input-error.html

+++ b/third_party/polymer/v1_0/components/paper-input/paper-input-error.html

@@ -35,8 +35,8 @@ Custom property | Description | Default

<style>

:host {

- /* need to use display: none for role="alert" */

- display: none;

+ display: inline-block;

+ visibility: hidden;

float: left;

color: var(--paper-input-container-invalid-color, --google-red-500);

@@ -46,7 +46,7 @@ Custom property | Description | Default

}

:host([invalid]) {

- display: inline-block;

+ visibility: visible;

};

</style>

@@ -71,10 +71,6 @@ Custom property | Description | Default

Polymer.PaperInputAddonBehavior

- hostAttributes: {

- 'role': 'alert'

- },

properties: {

/**