Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Issue 1221903004: SkAdvancedTypefaceMetrics zeroing constructor (Closed)

Created:
5 years, 5 months ago by hal.canary
Modified:
5 years, 5 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkAdvancedTypefaceMetrics zeroing constructor Committed: https://skia.googlesource.com/skia/+/0007bde42016f879db1ec564c9c64e9f2ffb6709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -38 lines) Patch
M src/core/SkAdvancedTypefaceMetrics.h View 1 chunk +13 lines, -1 line 0 comments Download
M src/fonts/SkTestScalerContext.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 3 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hal.canary
This was bothering me.
5 years, 5 months ago (2015-07-08 20:21:00 UTC) #2
caryclark
lgtm
5 years, 5 months ago (2015-07-08 20:42:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221903004/1
5 years, 5 months ago (2015-07-08 20:45:36 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 20:58:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0007bde42016f879db1ec564c9c64e9f2ffb6709

Powered by Google App Engine
This is Rietveld 408576698