Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: media/base/video_decoder_config.h

Issue 1221903003: Change the video color space default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable the JPEG blackwhite test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/video_decoder_config.h
diff --git a/media/base/video_decoder_config.h b/media/base/video_decoder_config.h
index 00de84e2fb56bc02e500b34d7b467806a0b1883e..63881bb7b61395bed9e16e0988d2a9b815521461 100644
--- a/media/base/video_decoder_config.h
+++ b/media/base/video_decoder_config.h
@@ -69,6 +69,12 @@ enum VideoCodecProfile {
class MEDIA_EXPORT VideoDecoderConfig {
public:
+ // Get the color space defaults. The default for src playbacks depends on
+ // whether the video is SD or HD.
+ static VideoFrame::ColorSpace DefaultMseColorSpace();
DaleCurtis 2015/07/06 22:36:14 How about just DefaultColorSpace() and MSE can har
watk 2015/07/06 23:15:58 Done.
+ static VideoFrame::ColorSpace DefaultSrcColorSpace(
+ const gfx::Size& natural_size);
+
// Constructs an uninitialized object. Clients should call Initialize() with
// appropriate values before using.
VideoDecoderConfig();
@@ -78,6 +84,7 @@ class MEDIA_EXPORT VideoDecoderConfig {
VideoDecoderConfig(VideoCodec codec,
VideoCodecProfile profile,
VideoFrame::Format format,
+ VideoFrame::ColorSpace color_space,
const gfx::Size& coded_size,
const gfx::Rect& visible_rect,
const gfx::Size& natural_size,
@@ -118,6 +125,11 @@ class MEDIA_EXPORT VideoDecoderConfig {
// Video format used to determine YUV buffer sizes.
VideoFrame::Format format() const;
+ // Default color space of the decoded frames. Decoders should output frames
+ // tagged with this color space unless they find a different value in the
+ // bitstream.
+ VideoFrame::ColorSpace color_space() const;
+
// Width and height of video frame immediately post-decode. Not all pixels
// in this region are valid.
gfx::Size coded_size() const;
@@ -144,6 +156,7 @@ class MEDIA_EXPORT VideoDecoderConfig {
VideoCodecProfile profile_;
VideoFrame::Format format_;
+ VideoFrame::ColorSpace color_space_;
gfx::Size coded_size_;
gfx::Rect visible_rect_;

Powered by Google App Engine
This is Rietveld 408576698