Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1221883002: Remove package:sky/framework (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1, Hixie
CC:
gregsimon, jackson_old, kulakowski, mojo-reviews_chromium.org, qsr+mojo_chromium.org, tonyg, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove package:sky/framework Please use package:sky/widgets instead. R=ianh@google.com, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/ac21cef12f1867925e97f96fea53e6d65c382c8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -35382 lines) Patch
M sky/sdk/BUILD.gn View 1 chunk +0 lines, -45 lines 0 comments Download
M sky/sdk/example/game/lib/sprites.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/game/main.dart View 1 chunk +1 line, -1 line 0 comments Download
D sky/sdk/example/old/stocks/README.md View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_0.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_1.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_10.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_11.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_12.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_13.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_14.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_15.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_16.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_17.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_18.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_19.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_2.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_20.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_21.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_22.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_23.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_24.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_25.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_26.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_27.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_28.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_29.json View 1 chunk +0 lines, -632 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_3.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_4.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_5.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_6.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_7.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_8.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/data/stock_data_9.json View 1 chunk +0 lines, -1002 lines 0 comments Download
D sky/sdk/example/old/stocks/lib/stock_app.dart View 1 chunk +0 lines, -225 lines 0 comments Download
D sky/sdk/example/old/stocks/lib/stock_arrow.dart View 1 chunk +0 lines, -93 lines 0 comments Download
D sky/sdk/example/old/stocks/lib/stock_data.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D sky/sdk/example/old/stocks/lib/stock_list.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D sky/sdk/example/old/stocks/lib/stock_menu.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D sky/sdk/example/old/stocks/lib/stock_row.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D sky/sdk/example/old/stocks/main.sky View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/sdk/example/old/stocks/pubspec.yaml View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/sdk/example/raw/touch-demo.sky View 1 chunk +0 lines, -70 lines 0 comments Download
M sky/sdk/example/stocks/lib/stock_data.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/stocks/lib/stock_menu.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/home.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/editing/keyboard.dart View 1 chunk +1 line, -1 line 0 comments Download
D sky/sdk/lib/framework/README.md View 1 chunk +0 lines, -8 lines 0 comments Download
D sky/sdk/lib/framework/animation/animated_value.dart View 1 chunk +0 lines, -83 lines 0 comments Download
D sky/sdk/lib/framework/animation/curves.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D sky/sdk/lib/framework/animation/fling_curve.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D sky/sdk/lib/framework/animation/generators.dart View 1 chunk +0 lines, -161 lines 0 comments Download
D sky/sdk/lib/framework/animation/mechanics.dart View 1 chunk +0 lines, -213 lines 0 comments Download
D sky/sdk/lib/framework/animation/scroll_behavior.dart View 1 chunk +0 lines, -114 lines 0 comments Download
D sky/sdk/lib/framework/components/animated_component.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D sky/sdk/lib/framework/components/button.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D sky/sdk/lib/framework/components/button_base.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D sky/sdk/lib/framework/components/checkbox.dart View 1 chunk +0 lines, -87 lines 0 comments Download
D sky/sdk/lib/framework/components/drawer.dart View 1 chunk +0 lines, -156 lines 0 comments Download
D sky/sdk/lib/framework/components/drawer_header.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D sky/sdk/lib/framework/components/fixed_height_scrollable.dart View 1 chunk +0 lines, -106 lines 0 comments Download
D sky/sdk/lib/framework/components/floating_action_button.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D sky/sdk/lib/framework/components/icon.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D sky/sdk/lib/framework/components/icon_button.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D sky/sdk/lib/framework/components/ink_splash.dart View 1 chunk +0 lines, -141 lines 0 comments Download
D sky/sdk/lib/framework/components/ink_well.dart View 1 chunk +0 lines, -119 lines 0 comments Download
D sky/sdk/lib/framework/components/input.dart View 1 chunk +0 lines, -96 lines 0 comments Download
D sky/sdk/lib/framework/components/material.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D sky/sdk/lib/framework/components/menu_divider.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/sdk/lib/framework/components/menu_item.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D sky/sdk/lib/framework/components/modal_overlay.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D sky/sdk/lib/framework/components/popup_menu.dart View 1 chunk +0 lines, -115 lines 0 comments Download
D sky/sdk/lib/framework/components/popup_menu_item.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D sky/sdk/lib/framework/components/radio.dart View 1 chunk +0 lines, -63 lines 0 comments Download
D sky/sdk/lib/framework/components/scaffold.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D sky/sdk/lib/framework/components/scrollable.dart View 1 chunk +0 lines, -146 lines 0 comments Download
D sky/sdk/lib/framework/components/tool_bar.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D sky/sdk/lib/framework/debug/shake-to-reload.sky View 1 chunk +0 lines, -41 lines 0 comments Download
D sky/sdk/lib/framework/debug/tracing.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/sdk/lib/framework/editing/editable_string.dart View 1 chunk +0 lines, -122 lines 0 comments Download
D sky/sdk/lib/framework/editing/editable_text.dart View 1 chunk +0 lines, -90 lines 0 comments Download
D sky/sdk/lib/framework/editing/keyboard.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/sdk/lib/framework/embedder.dart View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/sdk/lib/framework/fn.dart View 1 chunk +0 lines, -961 lines 0 comments Download
D sky/sdk/lib/framework/layout.dart View 1 chunk +0 lines, -562 lines 0 comments Download
D sky/sdk/lib/framework/net/fetch.dart View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/sdk/lib/framework/node.dart View 1 chunk +0 lines, -82 lines 0 comments Download
D sky/sdk/lib/framework/reflect.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D sky/sdk/lib/framework/shell.dart View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/sdk/lib/framework/theme/colors.dart View 1 chunk +0 lines, -252 lines 0 comments Download
D sky/sdk/lib/framework/theme/shadows.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D sky/sdk/lib/framework/theme/typography.dart View 1 chunk +0 lines, -56 lines 0 comments Download
D sky/sdk/lib/framework/theme/view_configuration.dart View 1 chunk +0 lines, -29 lines 0 comments Download
M sky/tests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/framework/basic.sky View 1 chunk +0 lines, -22 lines 0 comments Download
D sky/tests/framework/basic-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D sky/tests/framework/flights-app-pixels.sky View 1 chunk +0 lines, -338 lines 0 comments Download
D sky/tests/framework/flights-app-pixels-expected.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/framework/resources/ba.jpg View Binary file 0 comments Download
D sky/tests/framework/resources/basic.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/tests/framework/resources/delta.jpg View Binary file 0 comments Download
D sky/tests/framework/resources/jetblue.jpg View Binary file 0 comments Download
D sky/tests/framework/resources/magnifying-glass.png View Binary file 0 comments Download
D sky/tests/framework/resources/menu-disabled.png View Binary file 0 comments Download
D sky/tests/framework/resources/menu-enabled.png View Binary file 0 comments Download
D sky/tests/framework/resources/menu-pressed.png View Binary file 0 comments Download
D sky/tests/framework/resources/menu-white.png View Binary file 0 comments Download
D sky/tests/framework/resources/united.jpg View Binary file 0 comments Download
D sky/tests/framework/resources/virgin-america.jpg View Binary file 0 comments Download
M sky/tests/resources/event-sender.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/event-sender.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/network.sky View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-06-30 18:56:28 UTC) #1
Hixie
lgtm
5 years, 5 months ago (2015-06-30 19:01:38 UTC) #3
abarth-chromium
5 years, 5 months ago (2015-06-30 19:02:00 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ac21cef12f1867925e97f96fea53e6d65c382c8e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698