content/browser/tracing/tracing_controller_impl.cc - Issue 1221873002: Change sampler code events phase from instant to meta.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/tracing_controller_impl.cc

Issue 1221873002: Change sampler code events phase from instant to meta. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/tracing/tracing_controller_impl.cc

diff --git a/content/browser/tracing/tracing_controller_impl.cc b/content/browser/tracing/tracing_controller_impl.cc

index ed94a3ddd36dfac7fa2bb044ee4cbbea3f99e2ec..55e1a0edc12f784968fa623a0a230539b3d36302 100644

--- a/content/browser/tracing/tracing_controller_impl.cc

+++ b/content/browser/tracing/tracing_controller_impl.cc

@@ -288,10 +288,12 @@ bool TracingControllerImpl::StartTracing(

void TracingControllerImpl::OnAllTracingAgentsStarted() {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- TRACE_EVENT_API_ADD_METADATA_EVENT("IsTimeTicksHighResolution", "value",

- base::TimeTicks::IsHighResolution());

TRACE_EVENT_API_ADD_METADATA_EVENT(

- "TraceConfig", "value",

+ TraceLog::GetCategoryGroupEnabled("__metadata"),

+ "IsTimeTicksHighResolution", "value",

+ base::TimeTicks::IsHighResolution());

+ TRACE_EVENT_API_ADD_METADATA_EVENT(

+ TraceLog::GetCategoryGroupEnabled("__metadata"), "TraceConfig", "value",

start_tracing_trace_config_->AsConvertableToTraceFormat());

// Notify all child processes.

« no previous file with comments | « base/trace_event/trace_log.cc ('k') | content/renderer/devtools/v8_sampling_profiler.cc » ('j') | no next file with comments »