base/trace_event/trace_event_unittest.cc - Issue 1221873002: Change sampler code events phase from instant to meta.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_unittest.cc

Issue 1221873002: Change sampler code events phase from instant to meta. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/trace_event_unittest.cc

diff --git a/base/trace_event/trace_event_unittest.cc b/base/trace_event/trace_event_unittest.cc

index f3dc16dd43d9b44fa7137418d5edb71caa9f1226..eea84b9cbe22326af0e7835acbd7e6d147990fea 100644

--- a/base/trace_event/trace_event_unittest.cc

+++ b/base/trace_event/trace_event_unittest.cc

@@ -1251,8 +1251,9 @@ TEST_F(TraceEventTestFixture, AddMetadataEvent) {

new Convertable(&num_calls);

BeginTrace();

- TRACE_EVENT_API_ADD_METADATA_EVENT("metadata_event_name", "metadata_arg_name",

- convertable);

+ TRACE_EVENT_API_ADD_METADATA_EVENT(

+ TraceLog::GetCategoryGroupEnabled("__metadata"), "metadata_event_name",

+ "metadata_arg_name", convertable);

// |AppendAsTraceFormat| should only be called on flush, not when the event

// is added.

« no previous file with comments | « base/trace_event/trace_event.h ('k') | base/trace_event/trace_log.h » ('j') | no next file with comments »