Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: content/renderer/devtools/v8_sampling_profiler.cc

Issue 1221873002: Change sampler code events phase from instant to meta. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/trace_event.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/devtools/v8_sampling_profiler.cc
diff --git a/content/renderer/devtools/v8_sampling_profiler.cc b/content/renderer/devtools/v8_sampling_profiler.cc
index cdad93b20063b65d286b637f5911fe185965bd60..ddbc28e53f307298cd21baadbdc67719319b7ce8 100644
--- a/content/renderer/devtools/v8_sampling_profiler.cc
+++ b/content/renderer/devtools/v8_sampling_profiler.cc
@@ -327,23 +327,23 @@ void Sampler::HandleJitCodeEvent(const v8::JitCodeEvent* event) {
return;
switch (event->type) {
case v8::JitCodeEvent::CODE_ADDED:
- TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("v8.cpu_profile"),
- "JitCodeAdded", TRACE_EVENT_SCOPE_THREAD, "data",
- JitCodeEventToTraceFormat(event));
+ TRACE_EVENT_METADATA1(TRACE_DISABLED_BY_DEFAULT("v8.cpu_profile"),
+ "JitCodeAdded", TRACE_EVENT_SCOPE_THREAD, "data",
dsinclair 2015/06/30 18:14:17 What does SCOPE_THREAD mean for a metadata event?
alph 2015/07/01 12:28:08 Not really needed, but I thought it might be usefu
+ JitCodeEventToTraceFormat(event));
base::subtle::NoBarrier_AtomicIncrement(
&sampler->code_added_events_count_, 1);
break;
case v8::JitCodeEvent::CODE_MOVED:
- TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("v8.cpu_profile"),
- "JitCodeMoved", TRACE_EVENT_SCOPE_THREAD, "data",
- JitCodeEventToTraceFormat(event));
+ TRACE_EVENT_METADATA1(TRACE_DISABLED_BY_DEFAULT("v8.cpu_profile"),
+ "JitCodeMoved", TRACE_EVENT_SCOPE_THREAD, "data",
+ JitCodeEventToTraceFormat(event));
break;
case v8::JitCodeEvent::CODE_REMOVED:
- TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("v8.cpu_profile"),
- "JitCodeRemoved", TRACE_EVENT_SCOPE_THREAD, "data",
- JitCodeEventToTraceFormat(event));
+ TRACE_EVENT_METADATA1(TRACE_DISABLED_BY_DEFAULT("v8.cpu_profile"),
+ "JitCodeRemoved", TRACE_EVENT_SCOPE_THREAD, "data",
+ JitCodeEventToTraceFormat(event));
break;
case v8::JitCodeEvent::CODE_ADD_LINE_POS_INFO:
« no previous file with comments | « base/trace_event/trace_event.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698