Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1221853003: Add SkSurface factory for wrapping an FBO in SkSurface (Closed)

Created:
5 years, 5 months ago by bsalomon
Modified:
5 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add SkSurface factory for wrapping an FBO in SkSurface Committed: https://skia.googlesource.com/skia/+/d3e259a16cf85454f629f5fe75b60b9863c1e138

Patch Set 1 #

Patch Set 2 : rename test func #

Patch Set 3 : updated names and signature #

Total comments: 1

Patch Set 4 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -75 lines) Patch
M include/core/SkSurface.h View 1 2 3 1 chunk +20 lines, -4 lines 0 comments Download
M src/image/SkSurface.cpp View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 2 2 chunks +20 lines, -2 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 2 3 chunks +98 lines, -68 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bsalomon
5 years, 5 months ago (2015-06-30 18:38:04 UTC) #2
reed1
lgtm https://codereview.chromium.org/1221853003/diff/40001/include/core/SkSurface.h File include/core/SkSurface.h (right): https://codereview.chromium.org/1221853003/diff/40001/include/core/SkSurface.h#newcode107 include/core/SkSurface.h:107: * ownership of the render target and the ...
5 years, 5 months ago (2015-06-30 18:56:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221853003/60001
5 years, 5 months ago (2015-06-30 18:57:35 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 19:04:45 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/d3e259a16cf85454f629f5fe75b60b9863c1e138

Powered by Google App Engine
This is Rietveld 408576698