Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Issue 122183004: Don't modify the PWD in gyp_v8 (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 11 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Don't modify the PWD in gyp_v8 When running gyp in parallel mode (soon the default), we need to be able to find the script by looking at the path relative to the PWD when the script was originally invoked. Instead of changing the directory and relying on relative paths, just use absolute paths (as gyp_chromium does). BUG=v8:2973 R=ulan@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M build/gyp_v8 View 2 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-02 13:19:15 UTC) #1
ulan
lgtm
6 years, 11 months ago (2014-01-02 13:49:12 UTC) #2
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-02 13:51:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18439 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698