Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 12218135: Enlarge clickable area of the Files.app's butter bar's close action (x). (Closed)

Created:
7 years, 10 months ago by mtomasz
Modified:
7 years, 10 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Enlarge clickable area of the Files.app's butter bar's close action (x). The previous (x) button was very tiny - 16x16 pixels, which may be too small when using a touchpad. This patch modifies css so the x button's clickable area is extended to the surrounding paddings. As a result, it is much easier to cancel an operation. Along the way, simplified css for actions. TEST=Copy a large file and try to cancel. Also delete to check if Undo link is not broken. BUG=175950 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtomasz
@yoshiki: PTAL.
7 years, 10 months ago (2013-02-13 07:36:44 UTC) #1
yoshiki
lgtm
7 years, 10 months ago (2013-02-13 07:37:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12218135/1
7 years, 10 months ago (2013-02-13 07:43:31 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 16:47:09 UTC) #4
Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

Powered by Google App Engine
This is Rietveld 408576698