sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart - Issue 12218131: Combine window.setTimeout/setInterval with Timer and Timer.repeating. Also

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

Issue 12218131: Combine window.setTimeout/setInterval with Timer and Timer.repeating. Also (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« samples/third_party/dromaeo/tests/RunnerSuite.dart ('K') | « samples/third_party/dromaeo/tests/RunnerSuite.dart ('k') | sdk/lib/html/dart2js/html_dart2js.dart » ('j') | tests/html/js_interop_3_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

index 54bbdc140c44b724ca5e6aee8cf8bdd7c229f86d..dd8cc310e005580af8f0d3f83b406773415103c6 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

@@ -1315,6 +1315,7 @@ class TimerImpl implements Timer {

_globalState.topEventLoop.activeTimerCount--;

if (_once) {

JS('void', '#.clearTimeout(#)', globalThis, _handle);

+ JS('void', '#.clearImmediate(#)', globalThis, _handle);

blois 2013/02/13 03:09:24 Is the handle guaranteed to be unique between thes

Emily Fortuna 2013/02/13 20:19:44 Thank you -- yes. I had intended to go back and fi

Emily Fortuna 2013/02/13 20:19:44 No, removed.

} else {

JS('void', '#.clearInterval(#)', globalThis, _handle);

}