Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12218126: Only allow one frontbuffer on Android (Closed)

Created:
7 years, 10 months ago by ccameron
Modified:
7 years, 10 months ago
Reviewers:
epenner, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Only allow one frontbuffer on Android As far as everyone remembers, M18 didn't keep around anything more than 1 frontbuffer, so this restores this behavior. BUG=174572 R=epenner Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182092

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix reversed orders #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/common/gpu/gpu_memory_manager.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ccameron
7 years, 10 months ago (2013-02-12 21:51:59 UTC) #1
ccameron
And adding piman for content review
7 years, 10 months ago (2013-02-12 22:12:00 UTC) #2
epenner
https://codereview.chromium.org/12218126/diff/1/content/common/gpu/gpu_memory_manager.h File content/common/gpu/gpu_memory_manager.h (left): https://codereview.chromium.org/12218126/diff/1/content/common/gpu/gpu_memory_manager.h#oldcode31 content/common/gpu/gpu_memory_manager.h:31: enum { kDefaultMaxSurfacesWithFrontbufferSoftLimit = 8 }; This looks reversed.
7 years, 10 months ago (2013-02-12 22:28:18 UTC) #3
piman
https://codereview.chromium.org/12218126/diff/1/content/common/gpu/gpu_memory_manager.h File content/common/gpu/gpu_memory_manager.h (left): https://codereview.chromium.org/12218126/diff/1/content/common/gpu/gpu_memory_manager.h#oldcode31 content/common/gpu/gpu_memory_manager.h:31: enum { kDefaultMaxSurfacesWithFrontbufferSoftLimit = 8 }; On 2013/02/12 22:28:19, ...
7 years, 10 months ago (2013-02-12 22:31:16 UTC) #4
ccameron
Ack, yes, you're right! Fixed.
7 years, 10 months ago (2013-02-12 22:41:14 UTC) #5
piman
lgtm
7 years, 10 months ago (2013-02-12 22:47:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/12218126/5001
7 years, 10 months ago (2013-02-12 23:03:27 UTC) #7
ccameron
7 years, 10 months ago (2013-02-13 22:36:20 UTC) #8
Message was sent while issue was closed. 
On 2013/02/12 23:03:27, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/ccameron%40chromium.org/12218126/5001

Ugh, jeez, when I committed this, I picked up the wrong version of the patch.

Powered by Google App Engine
This is Rietveld 408576698