Chromium Code Reviews| Index: chrome/browser/component_updater/pepper_flash_component_installer.cc |
| diff --git a/chrome/browser/component_updater/pepper_flash_component_installer.cc b/chrome/browser/component_updater/pepper_flash_component_installer.cc |
| index 93135c4b0b15c48b85063620dd823dc7bc2dd5dc..7232e454efa41f873a5063cd5640ea7e09a69361 100644 |
| --- a/chrome/browser/component_updater/pepper_flash_component_installer.cc |
| +++ b/chrome/browser/component_updater/pepper_flash_component_installer.cc |
| @@ -188,10 +188,12 @@ void RegisterPepperFlashWithChrome(const base::FilePath& path, |
| if (!IsPepperFlash(*it)) |
| continue; |
| - // If the version we're trying to register is older than the existing one, |
| - // don't do it. |
| - if (version.IsOlderThan(UTF16ToUTF8(it->version))) |
| + // Do it only if the version we're trying to register is newer. |
| + Version registered_version(UTF16ToUTF8(it->version)); |
| + if (registered_version.IsValid() && |
| + version.CompareTo(registered_version) <= 0) { |
| return; |
|
cpu_(ooo_6.6-7.5)
2013/02/12 22:18:17
why not
registered_version.IsOlderThan(version)
yzshen1
2013/02/12 22:27:19
That is because IsOlderThan() receives a string, s
|
| + } |
| // If the version is newer, remove the old one first. |
| PluginService::GetInstance()->UnregisterInternalPlugin(it->path); |