Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 12218122: Revert pagescale from plugin placeholder (Closed)

Created:
7 years, 10 months ago by qinmin
Modified:
7 years, 10 months ago
Reviewers:
Bernhard Bauer, jamesr, jam
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Revert pagescale from plugin placeholder For impl-side painting, page scales are directly applied to cc. As a result, we are no longer using old style css based page scale transforms. Revert all the changes we made in https://codereview.chromium.org/11359200/ as this is no longer needed BUG=175121 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182076

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
M webkit/plugins/webview_plugin.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/plugins/webview_plugin.cc View 3 chunks +1 line, -22 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qinmin
PTAL
7 years, 10 months ago (2013-02-12 20:00:20 UTC) #1
Bernhard Bauer
Rubberstamp LGTM.
7 years, 10 months ago (2013-02-12 21:36:13 UTC) #2
Bernhard Bauer
Rubberstamp LGTM.
7 years, 10 months ago (2013-02-12 21:44:02 UTC) #3
qinmin
@Jam, I need owner's LGTM so I can merge this to M25 for android.
7 years, 10 months ago (2013-02-12 23:22:33 UTC) #4
jamesr
7 years, 10 months ago (2013-02-13 01:03:05 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698