Issue 12218114: Added missing assets for selected buttons in Files.app's photo editor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12218114: Added missing assets for selected buttons in Files.app's photo editor. (Closed)

Created:
7 years, 10 months ago by mtomasz

Modified:
7 years, 10 months ago

Reviewers:
Haruki Sato

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added missing assets for selected buttons in Files.app's photo editor. Two buttons - undo and redo were missing selected entities. As a result, when clicking on one of these buttons, the icon was white on a white background. TEST=Open Files.app, click on a picture, click on the edit button, rotate left, click on undo and check the clicked icon. The same for redo. BUG=170288 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181912

Patch Set 1 #

Patch Set 2 : Added missing assets. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, --4 lines)			Patch
M	chrome/browser/resources/file_manager/css/gallery.css	View		2 chunks	+14 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/2x/icon_redo_selected.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/2x/icon_undo_selected.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/icon_redo_selected.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/gallery/icon_undo_selected.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Haruki Sato

lgtm please pngcrush the images if you haven't. Thank you for the fix!

7 years, 10 months ago (2013-02-12 07:19:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12218114/2001

7 years, 10 months ago (2013-02-12 08:36:17 UTC) #3

commit-bot: I haz the power

7 years, 10 months ago (2013-02-12 10:24:56 UTC) #4

Retried try job too often on win_rel for step(s) media_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages