sdk/lib/_internal/compiler/implementation/lib/native_helper.dart - Issue 12218111: Allowing Window.onBeforeUnload event to work properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/native_helper.dart

Issue 12218111: Allowing Window.onBeforeUnload event to work properly. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Adding support for FireFox Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart ('k') | sdk/lib/html/dart2js/html_dart2js.dart » ('j') | sdk/lib/html/dart2js/html_dart2js.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/lib/native_helper.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/native_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/native_helper.dart

index c75e554e5a719776f2e42a677db1e1dbd21da810..64363a2bce97a2c46e0639c0b05372541167256f 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/native_helper.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/native_helper.dart

@@ -41,6 +41,7 @@ String typeNameInOpera(obj) {

String typeNameInFirefox(obj) {

String name = JS('String', '#', constructorNameFallback(obj));

if (name == 'Window') return 'DOMWindow';

+ if (name == 'BeforeUnloadEvent') return 'Event';

if (name == 'CSS2Properties') return 'CSSStyleDeclaration';

if (name == 'DataTransfer') return 'Clipboard';

if (name == 'DragEvent') return 'MouseEvent';

@@ -62,6 +63,7 @@ String typeNameInIE(obj) {

return 'HTMLDocument';

}

if (name == 'ApplicationCache') return 'DOMApplicationCache';

+ if (name == 'BeforeUnloadEvent') return 'Event';

if (name == 'CanvasPixelArray') return 'Uint8ClampedArray';

if (name == 'DataTransfer') return 'Clipboard';

if (name == 'DragEvent') return 'MouseEvent';