Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 12218099: Disable native messaging in non-supported configurations (Closed)

Created:
7 years, 10 months ago by Sergey Ulanov
Modified:
7 years, 10 months ago
Reviewers:
Nico, Matt Perry
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Disable native messaging in non-supported configurations. Native Messaging API is useful only on desktop OSes, i.e. on Linux, OSX and Windows. Disable it in all other configurations. Also improved how we handle the case when native messaging is disabled is handled: now the app will get disconnect notification. BUG=142915 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182197

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/browser/extensions/api/messaging/message_service.cc View 1 2 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sergey Ulanov
7 years, 10 months ago (2013-02-11 22:37:21 UTC) #1
Matt Perry
lgtm https://codereview.chromium.org/12218099/diff/1/chrome/browser/extensions/api/messaging/message_service.cc File chrome/browser/extensions/api/messaging/message_service.cc (right): https://codereview.chromium.org/12218099/diff/1/chrome/browser/extensions/api/messaging/message_service.cc#newcode235 chrome/browser/extensions/api/messaging/message_service.cc:235: #endif // !(defined(OS_WIN) || defined(OS_MAXOSX) || defined(OS_LINUX)) nit: ...
7 years, 10 months ago (2013-02-11 22:44:54 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/12218099/diff/1/chrome/browser/extensions/api/messaging/message_service.cc File chrome/browser/extensions/api/messaging/message_service.cc (right): https://codereview.chromium.org/12218099/diff/1/chrome/browser/extensions/api/messaging/message_service.cc#newcode235 chrome/browser/extensions/api/messaging/message_service.cc:235: #endif // !(defined(OS_WIN) || defined(OS_MAXOSX) || defined(OS_LINUX)) On 2013/02/11 ...
7 years, 10 months ago (2013-02-13 01:15:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/12218099/6
7 years, 10 months ago (2013-02-13 01:17:56 UTC) #4
commit-bot: I haz the power
Presubmit check for 12218099-6 failed and returned exit status 1. INFO:root:Found 2 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-13 01:18:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/12218099/6
7 years, 10 months ago (2013-02-13 01:41:10 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 11:53:44 UTC) #7
Message was sent while issue was closed.
Change committed as 182197

Powered by Google App Engine
This is Rietveld 408576698