Implement a policy to autologin a public account.

chrome/browser/chromeos/login/existing_user_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_EXISTING_USER_CONTROLLER_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_EXISTING_USER_CONTROLLER_H_
 
 #include <string>
 
+#include "ash/wm/user_activity_observer.h"
 #include "base/callback_forward.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/string16.h"
 #include "base/time.h"
 #include "base/timer.h"
 #include "chrome/browser/chromeos/login/login_display.h"
 #include "chrome/browser/chromeos/login/login_performer.h"
@@ skipping 13 matching lines @@
 // ExistingUserController is used to handle login when someone has
 // already logged into the machine.
 // To use ExistingUserController create an instance of it and invoke Init.
 // When Init is called it creates LoginDisplay instance which encapsulates
 // all login UI implementation.
 // ExistingUserController maintains it's own life cycle and deletes itself when
 // the user logs in (or chooses to see other settings).
 class ExistingUserController : public LoginDisplay::Delegate,
                                public content::NotificationObserver,
                                public LoginPerformer::Delegate,
-                               public LoginUtils::Delegate {
+                               public LoginUtils::Delegate,
+                               public ash::UserActivityObserver {
  public:
   // All UI initialization is deferred till Init() call.
   explicit ExistingUserController(LoginDisplayHost* host);
   virtual ~ExistingUserController();
 
   // Returns the current existing user controller if it has been created.
   static ExistingUserController* current_controller() {
     return current_controller_;
   }
 
   // Creates and shows login UI for known users.
   void Init(const UserList& users);
 
   // Tells the controller to enter the Enterprise Enrollment screen when
   // appropriate.
   void DoAutoEnrollment();
 
   // Tells the controller to resume a pending login.
   void ResumeLogin();
 
+  // Start the public session auto-login timer.
+  void StartPublicSessionAutoLoginTimer();
+
+  // Stop the public session auto-login timer when a login attempt begins.
+  void StopPublicSessionAutoLoginTimer();
+
+  // UserActivityObserver::Observer implementation.

[bartfab (slow), 2013/02/25 16:51:23]

The overrides should follow the order in which the base classes are listed in
lines 41-45 above. Since UserActivityObserver is the last base class, overrides
for ExistingUserController should be declared last as well.

[dconnelly, 2013/02/26 18:04:15]

Done.

+  virtual void OnUserActivity() OVERRIDE;
+
   // LoginDisplay::Delegate: implementation
   virtual void CancelPasswordChangedFlow() OVERRIDE;
   virtual void CreateAccount() OVERRIDE;
   virtual void CreateLocallyManagedUser(const string16& display_name,
                                         const std::string& password) OVERRIDE;
   virtual void CompleteLogin(const std::string& username,
                              const std::string& password) OVERRIDE;
   virtual string16 GetConnectedNetworkName() OVERRIDE;
   virtual void Login(const std::string& username,
                      const std::string& password) OVERRIDE;
   virtual void MigrateUserData(const std::string& old_password) OVERRIDE;
   virtual void LoginAsRetailModeUser() OVERRIDE;
   virtual void LoginAsGuest() OVERRIDE;
   virtual void LoginAsPublicAccount(const std::string& username) OVERRIDE;
+  virtual void OnSigninScreenReady() OVERRIDE;
   virtual void OnUserSelected(const std::string& username) OVERRIDE;
   virtual void OnStartEnterpriseEnrollment() OVERRIDE;
   virtual void OnStartDeviceReset() OVERRIDE;
   virtual void ResyncUserData() OVERRIDE;
   virtual void SetDisplayEmail(const std::string& email) OVERRIDE;
   virtual void ShowWrongHWIDScreen() OVERRIDE;
   virtual void Signout() OVERRIDE;
 
   // content::NotificationObserver implementation.
   virtual void Observe(int type,
@@ skipping 12 matching lines @@
     return login_display_.get();
   }
 
   // Returns the LoginDisplayHost for this controller.
   LoginDisplayHost* login_display_host() {
     return host_;
   }
 
  private:
   friend class ExistingUserControllerTest;
+  friend class ExistingUserControllerAutoLoginUnitTests;
+  friend class ExistingUserControllerAutoLoginIntegrationTests;
   friend class MockLoginPerformerDelegate;
 
+  // Retrieve public session auto-login policy and update the timer.
+  void ConfigurePublicSessionAutoLogin();
+
+  // Trigger public session auto-login.
+  void OnPublicSessionAutoLoginTimerFire();
+
   // LoginPerformer::Delegate implementation:
   virtual void OnLoginFailure(const LoginFailure& error) OVERRIDE;
   virtual void OnLoginSuccess(
       const std::string& username,
       const std::string& password,
       bool pending_requests,
       bool using_oauth) OVERRIDE;
   virtual void OnOffTheRecordLoginSuccess() OVERRIDE;
   virtual void OnPasswordChangeDetected() OVERRIDE;
   virtual void WhiteListCheckFailed(const std::string& email) OVERRIDE;
@@ skipping 60 matching lines @@
                     std::string password,
                     LoginPerformer::AuthorizationMode auth_mode);
 
   void set_login_performer_delegate(LoginPerformer::Delegate* d) {
     login_performer_delegate_.reset(d);
   }
 
   // Updates the |login_display_| attached to this controller.
   void UpdateLoginDisplay(const UserList& users);
 
+  // Public session auto-login timer.
+  base::OneShotTimer<ExistingUserController> auto_login_timer_;

[bartfab (slow), 2013/02/25 16:51:23]

When I was adding the session length limiter, there was a lot of pushback
against always instantiating a timer for this purpose, even if the policy that
requires it is not set. The same could be said about the auto-login timer. It
will only actually be used on a tiny fraction of Chrome OS devices. Maybe better
wrap this in a scoped_ptr to keep memory usage minimal when auto-login is
disabled?

[dconnelly, 2013/02/26 18:04:15]

Done.

+
+  // Public session auto-login timeout, in milliseconds.
+  int public_session_auto_login_delay_;
+
+  // Username for public session auto-login.
+  std::string public_session_auto_login_username_;
+
   // Used to execute login operations.
   scoped_ptr<LoginPerformer> login_performer_;
 
   // Delegate for login performer to be overridden by tests.
   // |this| is used if |login_performer_delegate_| is NULL.
   scoped_ptr<LoginPerformer::Delegate> login_performer_delegate_;
 
   // Delegate to forward all login status events to.
   // Tests can use this to receive login status events.
   LoginStatusConsumer* login_status_consumer_;
@@ skipping 40 matching lines @@
   std::string online_succeeded_for_;
 
   // True if password has been changed for user who is completing sign in.
   // Set in OnLoginSuccess. Before that use LoginPerformer::password_changed().
   bool password_changed_;
 
   // True if auto-enrollment should be performed before starting the user's
   // session.
   bool do_auto_enrollment_;
 
+  // Whether the sign-in UI is finished loading.
+  bool signin_screen_ready_;
+
   // The username used for auto-enrollment, if it was triggered.
   std::string auto_enrollment_username_;
 
   // Callback to invoke to resume login, after auto-enrollment has completed.
   base::Closure resume_login_callback_;
 
   // Time when the signin screen was first displayed. Used to measure the time
   // from showing the screen until a successful login is performed.
   base::Time time_init_;
 
   // Timer for the interval to wait for the reboot after TPM error UI was shown.
   base::OneShotTimer<ExistingUserController> reboot_timer_;
 
   FRIEND_TEST_ALL_PREFIXES(ExistingUserControllerTest, ExistingUserLogin);
+  FRIEND_TEST_ALL_PREFIXES(ExistingUserControllerPublicSessionTest,

[bartfab (slow), 2013/02/25 16:51:23]

Since you already added the base classes of your tests as friends, you can proxy
any accesses to the ExistingUserController through these classes - no need to
make the tests themselves friends as well.

[dconnelly, 2013/02/26 18:04:15]

I tried that, it doesn't work.  From
https://code.google.com/p/googletest/wiki/AdvancedGuide#Private_Class_Members:
"Note that even though your fixture is a friend to your production class, your
tests are not automatically friends to it, as they are technically defined in
sub-classes of the fixture."

[bartfab (slow), 2013/02/28 10:21:33]

Yes. You need to implement the accesses to the ExistingUserController in helper
methods provided by your fixture, then call these from within the tests.

+                           ConfigureAutoLogin);
+  FRIEND_TEST_ALL_PREFIXES(ExistingUserControllerPublicSessionTest,
+                           OnAutoLoginFire);
 
   DISALLOW_COPY_AND_ASSIGN(ExistingUserController);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_EXISTING_USER_CONTROLLER_H_