chrome/browser/ui/web_applications/web_app_ui.cc - Issue 12218069: CreateShortcutIcon on Linux now creates icons at all available resolutions, not

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/web_applications/web_app_ui.cc

Issue 12218069: CreateShortcutIcon on Linux now creates icons at all available resolutions, not (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Checking return values and correctly initializing vector. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/web_applications/web_app_ui.cc

diff --git a/chrome/browser/ui/web_applications/web_app_ui.cc b/chrome/browser/ui/web_applications/web_app_ui.cc

index 783b49b4ab6085ee25b5d7383098e5f74a4adc49..5684b508a6f5a98569b34e6e727c58b7d3f31c72 100644

--- a/chrome/browser/ui/web_applications/web_app_ui.cc

+++ b/chrome/browser/ui/web_applications/web_app_ui.cc

@@ -46,6 +46,10 @@ namespace {

#if defined(OS_MACOSX)

const int kDesiredSizes[] = {16, 32, 128, 256, 512};

+#elif defined(OS_LINUX)

+// Linux supports icons of any size. FreeDesktop Icon Theme Specification states

+// that "Minimally you should install a 48x48 icon in the hicolor theme."

+const int kDesiredSizes[] = {16, 32, 48, 128, 256, 512};

#else

const int kDesiredSizes[] = {32};

#endif

« no previous file with comments | « chrome/browser/shell_integration_linux.cc ('k') | no next file » | no next file with comments »