Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Unified Diff: chrome/browser/resources/history/history.js

Issue 12218058: History: Use images instead of unicode characters. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use link-buttons Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/history/history.js
diff --git a/chrome/browser/resources/history/history.js b/chrome/browser/resources/history/history.js
index 66dcc1096519c624287190f32aab9807d7daca9f..e7b9a8cd1a4b5959810b6f06e544480fa9302687 100644
--- a/chrome/browser/resources/history/history.js
+++ b/chrome/browser/resources/history/history.js
@@ -865,13 +865,16 @@ HistoryView.prototype.getGroupedVisitsDOM_ = function(
createElementWithClassName('div', 'site-domain-wrapper'));
var siteArrow = siteDomainWrapper.appendChild(
createElementWithClassName('div', 'site-domain-arrow collapse'));
- siteArrow.textContent = '►';
var siteDomain = siteDomainWrapper.appendChild(
createElementWithClassName('div', 'site-domain'));
+ var siteDomainLink = siteDomain.appendChild(
+ createElementWithClassName('a', 'link-button'));
James Hawkins 2013/02/08 17:19:25 The thing about link-buttons is that you should no
Sergiu 2013/02/11 19:19:34 Didn't know that but I do know :). Replaced it wit
+ siteDomainLink.href = '#';
+ siteDomainLink.addEventListener('click', function(e) { e.preventDefault(); });
+ siteDomainLink.textContent = domain;
var numberOfVisits = createElementWithClassName('span', 'number-visits');
numberOfVisits.textContent = loadTimeData.getStringF('numbervisits',
domainVisits.length);
- siteDomain.textContent = domain;
siteDomain.appendChild(numberOfVisits);
siteResults.appendChild(siteDomainWrapper);
var resultsList = siteResults.appendChild(

Powered by Google App Engine
This is Rietveld 408576698