chrome/browser/resources/history/history.js - Issue 12218058: History: Use images instead of unicode characters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/history/history.js

Issue 12218058: History: Use images instead of unicode characters. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/history/history.js

diff --git a/chrome/browser/resources/history/history.js b/chrome/browser/resources/history/history.js

index 66dcc1096519c624287190f32aab9807d7daca9f..cb070cde6613b830b41b1033b395a0fd939135e7 100644

--- a/chrome/browser/resources/history/history.js

+++ b/chrome/browser/resources/history/history.js

@@ -865,7 +865,10 @@ HistoryView.prototype.getGroupedVisitsDOM_ = function(

createElementWithClassName('div', 'site-domain-wrapper'));

var siteArrow = siteDomainWrapper.appendChild(

createElementWithClassName('div', 'site-domain-arrow collapse'));

- siteArrow.textContent = '►';

+ var siteArrowLink = siteArrow.appendChild(

Patrick Dubroy 2013/02/07 18:49:24 I think the arrow should be a background image of

+ createElementWithClassName('a', 'site-arrow-button'));

+ siteArrowLink.href = '#';

+ siteArrowLink.addEventListener('click', function(e) { e.preventDefault(); });

var siteDomain = siteDomainWrapper.appendChild(

createElementWithClassName('div', 'site-domain'));

var numberOfVisits = createElementWithClassName('span', 'number-visits');