Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 <include src="../uber/uber_utils.js"> | 5 <include src="../uber/uber_utils.js"> |
| 6 | 6 |
| 7 /////////////////////////////////////////////////////////////////////////////// | 7 /////////////////////////////////////////////////////////////////////////////// |
| 8 // Globals: | 8 // Globals: |
| 9 /** @const */ var RESULTS_PER_PAGE = 150; | 9 /** @const */ var RESULTS_PER_PAGE = 150; |
| 10 | 10 |
| (...skipping 847 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 858 HistoryView.prototype.getGroupedVisitsDOM_ = function( | 858 HistoryView.prototype.getGroupedVisitsDOM_ = function( |
| 859 results, domain, domainVisits) { | 859 results, domain, domainVisits) { |
| 860 // Add a new domain entry. | 860 // Add a new domain entry. |
| 861 var siteResults = results.appendChild( | 861 var siteResults = results.appendChild( |
| 862 createElementWithClassName('li', 'site-entry')); | 862 createElementWithClassName('li', 'site-entry')); |
| 863 // Make a wrapper that will contain the arrow, the favicon and the domain. | 863 // Make a wrapper that will contain the arrow, the favicon and the domain. |
| 864 var siteDomainWrapper = siteResults.appendChild( | 864 var siteDomainWrapper = siteResults.appendChild( |
| 865 createElementWithClassName('div', 'site-domain-wrapper')); | 865 createElementWithClassName('div', 'site-domain-wrapper')); |
| 866 var siteArrow = siteDomainWrapper.appendChild( | 866 var siteArrow = siteDomainWrapper.appendChild( |
| 867 createElementWithClassName('div', 'site-domain-arrow collapse')); | 867 createElementWithClassName('div', 'site-domain-arrow collapse')); |
| 868 siteArrow.textContent = '►'; | |
| 869 var siteDomain = siteDomainWrapper.appendChild( | 868 var siteDomain = siteDomainWrapper.appendChild( |
| 870 createElementWithClassName('div', 'site-domain')); | 869 createElementWithClassName('div', 'site-domain')); |
| 870 var siteDomainLink = siteDomain.appendChild( | |
| 871 createElementWithClassName('a', 'link-button')); | |
|
James Hawkins
2013/02/08 17:19:25
The thing about link-buttons is that you should no
Sergiu
2013/02/11 19:19:34
Didn't know that but I do know :). Replaced it wit
| |
| 872 siteDomainLink.href = '#'; | |
| 873 siteDomainLink.addEventListener('click', function(e) { e.preventDefault(); }); | |
| 874 siteDomainLink.textContent = domain; | |
| 871 var numberOfVisits = createElementWithClassName('span', 'number-visits'); | 875 var numberOfVisits = createElementWithClassName('span', 'number-visits'); |
| 872 numberOfVisits.textContent = loadTimeData.getStringF('numbervisits', | 876 numberOfVisits.textContent = loadTimeData.getStringF('numbervisits', |
| 873 domainVisits.length); | 877 domainVisits.length); |
| 874 siteDomain.textContent = domain; | |
| 875 siteDomain.appendChild(numberOfVisits); | 878 siteDomain.appendChild(numberOfVisits); |
| 876 siteResults.appendChild(siteDomainWrapper); | 879 siteResults.appendChild(siteDomainWrapper); |
| 877 var resultsList = siteResults.appendChild( | 880 var resultsList = siteResults.appendChild( |
| 878 createElementWithClassName('ol', 'site-results')); | 881 createElementWithClassName('ol', 'site-results')); |
| 879 | 882 |
| 880 domainVisits[0].addFaviconToElement_(siteDomain); | 883 domainVisits[0].addFaviconToElement_(siteDomain); |
| 881 | 884 |
| 882 siteDomainWrapper.addEventListener('click', toggleHandler); | 885 siteDomainWrapper.addEventListener('click', toggleHandler); |
| 883 // Collapse until it gets toggled. | 886 // Collapse until it gets toggled. |
| 884 resultsList.style.height = 0; | 887 resultsList.style.height = 0; |
| (...skipping 660 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1545 historyView.reload(); | 1548 historyView.reload(); |
| 1546 } | 1549 } |
| 1547 | 1550 |
| 1548 // Add handlers to HTML elements. | 1551 // Add handlers to HTML elements. |
| 1549 document.addEventListener('DOMContentLoaded', load); | 1552 document.addEventListener('DOMContentLoaded', load); |
| 1550 | 1553 |
| 1551 // This event lets us enable and disable menu items before the menu is shown. | 1554 // This event lets us enable and disable menu items before the menu is shown. |
| 1552 document.addEventListener('canExecute', function(e) { | 1555 document.addEventListener('canExecute', function(e) { |
| 1553 e.canExecute = true; | 1556 e.canExecute = true; |
| 1554 }); | 1557 }); |
| OLD | NEW |