Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: chrome/browser/resources/history/history.js

Issue 12218058: History: Use images instead of unicode characters. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 <include src="../uber/uber_utils.js"> 5 <include src="../uber/uber_utils.js">
6 6
7 /////////////////////////////////////////////////////////////////////////////// 7 ///////////////////////////////////////////////////////////////////////////////
8 // Globals: 8 // Globals:
9 /** @const */ var RESULTS_PER_PAGE = 150; 9 /** @const */ var RESULTS_PER_PAGE = 150;
10 10
(...skipping 847 matching lines...) Expand 10 before | Expand all | Expand 10 after
858 HistoryView.prototype.getGroupedVisitsDOM_ = function( 858 HistoryView.prototype.getGroupedVisitsDOM_ = function(
859 results, domain, domainVisits) { 859 results, domain, domainVisits) {
860 // Add a new domain entry. 860 // Add a new domain entry.
861 var siteResults = results.appendChild( 861 var siteResults = results.appendChild(
862 createElementWithClassName('li', 'site-entry')); 862 createElementWithClassName('li', 'site-entry'));
863 // Make a wrapper that will contain the arrow, the favicon and the domain. 863 // Make a wrapper that will contain the arrow, the favicon and the domain.
864 var siteDomainWrapper = siteResults.appendChild( 864 var siteDomainWrapper = siteResults.appendChild(
865 createElementWithClassName('div', 'site-domain-wrapper')); 865 createElementWithClassName('div', 'site-domain-wrapper'));
866 var siteArrow = siteDomainWrapper.appendChild( 866 var siteArrow = siteDomainWrapper.appendChild(
867 createElementWithClassName('div', 'site-domain-arrow collapse')); 867 createElementWithClassName('div', 'site-domain-arrow collapse'));
868 siteArrow.textContent = '►'; 868 var siteArrowLink = siteArrow.appendChild(
Patrick Dubroy 2013/02/07 18:49:24 I think the arrow should be a background image of
869 createElementWithClassName('a', 'site-arrow-button'));
870 siteArrowLink.href = '#';
871 siteArrowLink.addEventListener('click', function(e) { e.preventDefault(); });
869 var siteDomain = siteDomainWrapper.appendChild( 872 var siteDomain = siteDomainWrapper.appendChild(
870 createElementWithClassName('div', 'site-domain')); 873 createElementWithClassName('div', 'site-domain'));
871 var numberOfVisits = createElementWithClassName('span', 'number-visits'); 874 var numberOfVisits = createElementWithClassName('span', 'number-visits');
872 numberOfVisits.textContent = loadTimeData.getStringF('numbervisits', 875 numberOfVisits.textContent = loadTimeData.getStringF('numbervisits',
873 domainVisits.length); 876 domainVisits.length);
874 siteDomain.textContent = domain; 877 siteDomain.textContent = domain;
875 siteDomain.appendChild(numberOfVisits); 878 siteDomain.appendChild(numberOfVisits);
876 siteResults.appendChild(siteDomainWrapper); 879 siteResults.appendChild(siteDomainWrapper);
877 var resultsList = siteResults.appendChild( 880 var resultsList = siteResults.appendChild(
878 createElementWithClassName('ol', 'site-results')); 881 createElementWithClassName('ol', 'site-results'));
(...skipping 666 matching lines...) Expand 10 before | Expand all | Expand 10 after
1545 historyView.reload(); 1548 historyView.reload();
1546 } 1549 }
1547 1550
1548 // Add handlers to HTML elements. 1551 // Add handlers to HTML elements.
1549 document.addEventListener('DOMContentLoaded', load); 1552 document.addEventListener('DOMContentLoaded', load);
1550 1553
1551 // This event lets us enable and disable menu items before the menu is shown. 1554 // This event lets us enable and disable menu items before the menu is shown.
1552 document.addEventListener('canExecute', function(e) { 1555 document.addEventListener('canExecute', function(e) {
1553 e.canExecute = true; 1556 e.canExecute = true;
1554 }); 1557 });
OLDNEW
« chrome/browser/resources/history/history.css ('K') | « chrome/browser/resources/history/history.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698