Issue 12218051: Fix NULL-pointer arithmetic abuse in tests surfaced by clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12218051: Fix NULL-pointer arithmetic abuse in tests surfaced by clang (Closed)

Created:
7 years, 10 months ago by danno

Modified:
7 years, 10 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix NULL-pointer arithmetic abuse in tests surfaced by clang R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13614

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review feedback #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	test/cctest/test-mark-compact.cc	View	1	2 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

7 years, 10 months ago (2013-02-07 09:02:10 UTC) #2

LGTM with a nit

https://codereview.chromium.org/12218051/diff/1/test/cctest/test-mark-compact.cc
File test/cctest/test-mark-compact.cc (right):

https://codereview.chromium.org/12218051/diff/1/test/cctest/test-mark-compact...
test/cctest/test-mark-compact.cc:77: CHECK_EQ(current_address,
original_address);
swap arguments to match expected/actual

Expand Messages | Collapse Messages