Issue 12218034: Make the GC stress builder go green.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12218034: Make the GC stress builder go green. (Closed)

Created:
7 years, 10 months ago by Michael Starzinger

Modified:
7 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make the GC stress builder go green. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=13608

Patch Set 2 : Addressed comments. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
M	test/cctest/cctest.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/mjsunit/regress/regress-165637.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM. https://codereview.chromium.org/12218034/diff/1/test/cctest/cctest.h File test/cctest/cctest.h (right): https://codereview.chromium.org/12218034/diff/1/test/cctest/cctest.h#newcode245 test/cctest/cctest.h:245: // Helper function that simulates a full new-space ...

7 years, 10 months ago (2013-02-06 12:55:56 UTC) #2

Michael Starzinger

7 years, 10 months ago (2013-02-06 13:20:49 UTC) #3

Addressed comments. Landing.

https://codereview.chromium.org/12218034/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/12218034/diff/1/test/cctest/test-api.cc#newco...
test/cctest/test-api.cc:11118: // TODO(mstarzinger): Disabled in GC stress mode
for now, we should fine the
On 2013/02/06 12:55:56, Jakob wrote:
> nit: s/fine/find/

Done.

Expand Messages | Collapse Messages

Issue 12218034: Make the GC stress builder go green. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments. #

Messages