Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: pkg/dart2js_incremental/lib/library_updater.dart

Issue 1221803009: Stop tracking constants in the incremental compiler. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dart2js_incremental/lib/library_updater.dart
diff --git a/pkg/dart2js_incremental/lib/library_updater.dart b/pkg/dart2js_incremental/lib/library_updater.dart
index f111d4a582952d5eeb717f4488e0414ccb4dd738..758211f68ab5e53bfa7d01ae93b4768021e2bbf7 100644
--- a/pkg/dart2js_incremental/lib/library_updater.dart
+++ b/pkg/dart2js_incremental/lib/library_updater.dart
@@ -155,14 +155,18 @@ class IncrementalCompilerContext extends _IncrementalCompilerContext {
void _captureState(Compiler compiler) {
JavaScriptBackend backend = compiler.backend;
- _emittedClasses = new Set.from(backend.emitter.neededClasses);
+ Set neededClasses = backend.emitter.neededClasses;
+ if (neededClasses == null) {
+ neededClasses = new Set();
+ }
+ _emittedClasses = new Set.from(neededClasses);
_directlyInstantiatedClasses =
new Set.from(compiler.codegenWorld.directlyInstantiatedClasses);
- List<ConstantValue> constants =
- backend.emitter.outputConstantLists[
- compiler.deferredLoadTask.mainOutputUnit];
+ // This breaks constant tracking of the incremental compiler. It would need
+ // to capture the emitted constants.
+ List<ConstantValue> constants = null;
if (constants == null) constants = <ConstantValue>[];
_compiledConstants = new Set<ConstantValue>.identity()..addAll(constants);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698