Unify all four JSConstructStub generators into one.

Unify all four JSConstructStub generators into one.

R=bmeurer@chromium.org

[Michael Starzinger, 2015-07-07 13:23:22]

As discussed offline: I would like to get a first round of comments before I do
the architecture ports. Also please advise in general whether this approach is
"cleaner" compared to before or not. I think it is, but I might be mistaken. :)

[arv (Not doing code reviews), 2015-07-07 16:32:25]

arv@chromium.org changed reviewers:
+ arv@chromium.org

[arv (Not doing code reviews), 2015-07-07 16:32:26]

I like

https://codereview.chromium.org/1221803004/diff/20001/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):

https://codereview.chromium.org/1221803004/diff/20001/src/ia32/builtins-ia32....
src/ia32/builtins-ia32.cc:538: void
Builtins::Generate_JSConstructStubNewTarget(MacroAssembler* masm) {
I think we should get rid of this stub and have JSConstructStubGeneric always
use new.target

[Michael Starzinger, 2015-07-07 16:46:59]

https://codereview.chromium.org/1221803004/diff/20001/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):

https://codereview.chromium.org/1221803004/diff/20001/src/ia32/builtins-ia32....
src/ia32/builtins-ia32.cc:538: void
Builtins::Generate_JSConstructStubNewTarget(MacroAssembler* masm) {
On 2015/07/07 16:32:26, arv wrote:
> I think we should get rid of this stub and have JSConstructStubGeneric always
> use new.target

Yes, oh god please yes, from the bottom of my heart, let's do that!

[Michael Starzinger, 2015-07-07 16:50:59]

https://codereview.chromium.org/1221803004/diff/20001/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):

https://codereview.chromium.org/1221803004/diff/20001/src/ia32/builtins-ia32....
src/ia32/builtins-ia32.cc:538: void
Builtins::Generate_JSConstructStubNewTarget(MacroAssembler* masm) {
On 2015/07/07 16:46:59, Michael Starzinger wrote:
> On 2015/07/07 16:32:26, arv wrote:
> > I think we should get rid of this stub and have JSConstructStubGeneric
always
> > use new.target
> 
> Yes, oh god please yes, from the bottom of my heart, let's do that!

To rephrase this in a more professional way: Agreed, I will do so in a follow-up
CL after this one.

[Benedikt Meurer, 2015-07-08 05:06:43]

LGTM.

[arv (Not doing code reviews), 2015-07-08 13:50:24]

LGTM

Did you want to do the other ports in this CL?

[Michael Starzinger, 2015-07-08 14:34:04]

Yes, will do the other ports tomorrow probably.

[Michael Starzinger, 2015-11-18 17:24:22]

Closing. This is being obsoleteted by:
https://codereview.chromium.org/1448933002/

[Michael Starzinger, 2015-11-18 17:24:28]

Description was changed from

==========
Unify all four JSConstructStub generators into one.

R=bmeurer@chromium.org
==========

to

==========
Unify all four JSConstructStub generators into one.

R=bmeurer@chromium.org
==========