Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 12218019: Check that callbackAdded callbacks are only called once. (Closed)

Created:
7 years, 10 months ago by not at google - send to devlin
Modified:
7 years, 10 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Check that callbackAdded callbacks are only called once. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181000

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/renderer/resources/extensions/apitest.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
not at google - send to devlin
Can't really tell if failures in try jobs are due to flakiness or due to ...
7 years, 10 months ago (2013-02-05 23:31:32 UTC) #1
Matt Perry
lgtm
7 years, 10 months ago (2013-02-05 23:36:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/12218019/1
7 years, 10 months ago (2013-02-05 23:47:09 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=108638
7 years, 10 months ago (2013-02-06 05:01:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/12218019/1
7 years, 10 months ago (2013-02-06 16:10:05 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-06 17:36:44 UTC) #6
Message was sent while issue was closed.
Change committed as 181000

Powered by Google App Engine
This is Rietveld 408576698