Source/bindings/tests/results/core/TestDictionary.cpp - Issue 1221743002: Teach Blink's IDL parser to handle defaulted sequences of strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/TestDictionary.cpp

Issue 1221743002: Teach Blink's IDL parser to handle defaulted sequences of strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@pinned

Patch Set: Use cpp_type() to serialize a type Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/tests/idls/core/TestDictionary.idl ('K') | « Source/bindings/tests/idls/core/TestDictionary.idl ('k') | Source/bindings/tests/results/core/V8TestDictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/TestDictionary.cpp

diff --git a/Source/bindings/tests/results/core/TestDictionary.cpp b/Source/bindings/tests/results/core/TestDictionary.cpp

index c9c7eecd4a90470992b6614e29d8dd8c98654597..fa1fd0e5e5357a72716990a1067075bf73a7485b 100644

--- a/Source/bindings/tests/results/core/TestDictionary.cpp

+++ b/Source/bindings/tests/results/core/TestDictionary.cpp

@@ -18,8 +18,9 @@ TestDictionary::TestDictionary()

setOtherDoubleOrStringMember(DoubleOrString::fromString(String("default string value")));

setRestrictedDoubleMember(3.14);

setStringOrNullMember(String("default string value"));

+ setStringSequenceMember(Vector<String>());

setTestInterfaceGarbageCollectedSequenceMember(HeapVector<Member<TestInterfaceGarbageCollected>>());

- setTestInterfaceSequenceMember(Vector<RefPtr<TestInterface>>());

+ setTestInterfaceSequenceMember(Vector<RefPtr<TestInterfaceImplementation>>());

Jeffrey Yasskin 2015/06/29 23:26:29 I think this is more correct. TestInterface is Imp

setTestInterfaceWillBeGarbageCollectedSequenceMember(WillBeHeapVector<RefPtrWillBeMember<TestInterfaceWillBeGarbageCollected>>());

setUnrestrictedDoubleMember(3.14);

}