Add test for ServiceManager

mojo/shell/context.h

Index: mojo/shell/context.h
diff --git a/mojo/shell/context.h b/mojo/shell/context.h
index 375a49b790e355e42a3671d9ee5cd44d7f328753..f1a72e4ed0ca769a3babbb749e866f581ce4a71a 100644
--- a/mojo/shell/context.h
+++ b/mojo/shell/context.h
@@ -18,6 +18,8 @@
 namespace mojo {
 namespace shell {
 
+class DynamicServiceLoader;
+
 class Context {
  public:
   Context();
@@ -26,7 +28,7 @@ class Context {
   TaskRunners* task_runners() { return &task_runners_; }
   Storage* storage() { return &storage_; }
   Loader* loader() { return &loader_; }
-  ServiceManager* service_manager() { return service_manager_.get(); }
+  ServiceManager* service_manager() { return &service_manager_; }
 
 #if defined(OS_ANDROID)
   jobject activity() const { return activity_.obj(); }
@@ -37,8 +39,9 @@ class Context {
   TaskRunners task_runners_;
   Storage storage_;
   Loader loader_;
+  ServiceManager service_manager_;

[viettrungluu, 2014/01/03 17:44:49]

Ordering: It seems bad that |service_manager_| (slightly) outlives
|dynamic_service_loader_|, yet is never told about |dynamic_service_loader_|'s
destruction.

Probably the order should be reversed here, and a comment added.

[DaveMoore, 2014/01/03 18:05:49]

I've reversed the order and set the default loader in Context's destructor.
On 2014/01/03 17:44:49, viettrungluu wrote:

+  scoped_ptr<DynamicServiceLoader> dynamic_service_loader_;
   common::BindingsSupportImpl bindings_support_impl_;
-  scoped_ptr<ServiceManager> service_manager_;
 
 #if defined(OS_ANDROID)
   base::android::ScopedJavaGlobalRef<jobject> activity_;