Add test for ServiceManager

mojo/shell/service_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_SHELL_SERVICE_MANAGER_H_
 #define MOJO_SHELL_SERVICE_MANAGER_H_
 
 #include <map>
 
 #include "base/callback.h"
 #include "mojo/public/system/core_cpp.h"
 #include "url/gurl.h"
 
 namespace mojo {
 namespace shell {
 
-class Context;
-
 class ServiceManager {
  public:
+  // Interface to allowing default loading behavior to be overridden for a
+  // specific url.
   class Loader {
    public:
     virtual ~Loader();
     virtual void Load(const GURL& url,
-                      ServiceManager* manager,
                       ScopedMessagePipeHandle service_handle) = 0;
    protected:
     Loader();
   };
 
-  explicit ServiceManager(Context* context);
+  ServiceManager();
   ~ServiceManager();
 
+  // Sets the default Loader to be used if not overridden by SetLoaderForURL().
+  void set_default_loader(Loader* loader) { default_loader_ = loader; }

[viettrungluu, 2014/01/03 17:44:49]

Who owns the default loader? (Someone else.)
And what are the requirements on its lifetime?

Or you could make set_default_loader() pass ownership (and take a scoped_ptr
argument).

[DaveMoore, 2014/01/03 18:05:49]

I thought it would be cleaner to have the Loaders owned externally, as they're
really part of configuration. So neither api takes ownership. I could be
convinced to change this if you feel strongly.
On 2014/01/03 17:44:49, viettrungluu wrote:

[viettrungluu, 2014/01/03 18:23:14]

I don't feel strongly, but then you should probably add a comment about
ownership/lifetime.

+  // Sets a Loader to be used for a specific url.
   void SetLoaderForURL(Loader* loader, const GURL& gurl);
+  // Returns the Loader to use for a url (using default if not overridden.)
   Loader* GetLoaderForURL(const GURL& gurl);
+  // Loads a service if necessary and establishes a new client connection.
   void Connect(const GURL& url, ScopedMessagePipeHandle client_handle);
 
  private:
   class Service;
-  class DynamicLoader;
 
-  Context* context_;
-  scoped_ptr<Loader> default_loader_;
+  Loader* default_loader_;
   typedef std::map<GURL, Service*> ServiceMap;
   ServiceMap url_to_service_;
   typedef std::map<GURL, Loader*> LoaderMap;
   LoaderMap url_to_loader_;
   DISALLOW_COPY_AND_ASSIGN(ServiceManager);

[viettrungluu, 2014/01/03 17:44:49]

nit: #include "base/basictypes.h", while you're at it.

[DaveMoore, 2014/01/03 18:05:49]

Done.

 };
 
 }  // namespace shell
 }  // namespace mojo
 
 #endif  // MOJO_SHELL_SERVICE_MANAGER_H_