Issue 12217165: net: Fix DCHECK failure on large file upload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12217165: net: Fix DCHECK failure on large file upload (Closed)

Created:
7 years, 10 months ago by hashimoto

Modified:
7 years, 10 months ago

Reviewers:
mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

net: Fix DCHECK failure on large file upload BUG=None TEST=No DCHECK failure on uploading 2GB+ files with Debug build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182394

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	net/base/upload_file_element_reader.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

mmenke

On 2013/02/13 08:15:41, hashimoto wrote: > Could you review this 2-line change? Gah, should have ...

7 years, 10 months ago (2013-02-13 13:33:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/12217165/1

7 years, 10 months ago (2013-02-14 02:22:38 UTC) #3

commit-bot: I haz the power

7 years, 10 months ago (2013-02-14 05:17:40 UTC) #4

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...