Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: sdk/lib/_internal/dartdoc/lib/dartdoc.dart

Issue 12217161: Add mdn docs to json, tag which classes are throwable, and provide additional information about par… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/dartdoc/lib/universe_serializer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/dartdoc/lib/dartdoc.dart
diff --git a/sdk/lib/_internal/dartdoc/lib/dartdoc.dart b/sdk/lib/_internal/dartdoc/lib/dartdoc.dart
index 9d515441a77a4283f20b7d3cd59c340818a920c9..1f3590acbb1319b535562a9630a230e666bd6823 100644
--- a/sdk/lib/_internal/dartdoc/lib/dartdoc.dart
+++ b/sdk/lib/_internal/dartdoc/lib/dartdoc.dart
@@ -157,7 +157,7 @@ class PackageManifest {
/** Package description */
final description;
/** Libraries contained in this package. */
- final List<String> libraries = <String>[];
+ final List<Reference> libraries = <Reference>[];
/**
* Descriptive string describing the version# of the package.
*
@@ -414,11 +414,10 @@ class Dartdoc {
version, revision);
for (final lib in _sortedLibraries) {
- var libraryElement = new LibraryElement(lib.qualifiedName, lib)
+ var libraryElement = new LibraryElement(lib.qualifiedName, lib, lookupMdnComment)
..stripDuplicateUris(null, null);
- packageManifest.libraries.add(libraryElement.id);
+ packageManifest.libraries.add(new Reference.fromElement(libraryElement));
startFile("$revision/${libraryElement.id}.json");
-
write(json_serializer.serialize(libraryElement));
endFile();
}
@@ -434,6 +433,8 @@ class Dartdoc {
write(json_serializer.serialize(packageManifest));
endFile();
}
+
+ MdnComment lookupMdnComment(Mirror mirror) => null;
void startFile(String path) {
_filePath = new Path(path);
@@ -1981,3 +1982,27 @@ class DocComment {
String toString() => text;
}
+
+class MdnComment implements DocComment {
+ final String mdnComment;
+ final String mdnUrl;
+
+ MdnComment(String this.mdnComment, String this.mdnUrl);
+
+ String get text => mdnComment;
+
+ ClassMirror get inheritedFrom => null;
+
+ String get html {
+ // Wrap the mdn comment so we can highlight it and so we handle MDN scraped
+ // content that lacks a top-level block tag.
+ return '''
+ <div class="mdn">
+ $mdnComment
+ <div class="mdn-note"><a href="$mdnUrl">from MDN</a></div>
+ </div>
+ ''';
+ }
+
+ String toString() => mdnComment;
+}
« no previous file with comments | « no previous file | sdk/lib/_internal/dartdoc/lib/universe_serializer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698