Fix NegateCompareOp and InvertCompareOp

src/token.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 212 matching lines @@
   static bool IsEqualityOp(Value op) {
     return op == EQ || op == EQ_STRICT;
   }
 
   static Value NegateCompareOp(Value op) {
     ASSERT(IsCompareOp(op));
     switch (op) {
       case EQ: return NE;
       case NE: return EQ;
       case EQ_STRICT: return NE_STRICT;
+      case NE_STRICT: return EQ_STRICT;
       case LT: return GTE;
       case GT: return LTE;
       case LTE: return GT;
       case GTE: return LT;
       default:
         return op;

[Michael Starzinger, 2013/02/13 11:01:18]

Same argumentation as below applies.

[Jakob Kummerow, 2013/02/13 14:35:43]

Done.

     }
   }
 
   static Value InvertCompareOp(Value op) {

[Sven Panne, 2013/02/13 11:59:30]

DBC: Can we rename this to "FlipCompareOp" or something similar? The semantic
difference between "Invert" and "Negate" is, well, 0... :-P

     ASSERT(IsCompareOp(op));
     switch (op) {
-      case EQ: return NE;
-      case NE: return EQ;
-      case EQ_STRICT: return NE_STRICT;
+      case EQ: return EQ;
+      case NE: return NE;
+      case EQ_STRICT: return EQ_STRICT;
+      case NE_STRICT: return NE_STRICT;
       case LT: return GT;
       case GT: return LT;
       case LTE: return GTE;
       case GTE: return LTE;
       default:
         return op;

[Michael Starzinger, 2013/02/13 11:01:18]

The "IN" and the "INSTANCEOF" operation cannot really be inverted I think. So
calling InvertCompareOp() on them would point to a bug I guess. Can we hence
change the default branch to assert that it's UNREACHABLE()?

[Jakob Kummerow, 2013/02/13 14:35:43]

Done.

     }
   }
 
   static bool IsBitOp(Value op) {
     return (BIT_OR <= op && op <= SHR) || op == BIT_NOT;
   }
 
   static bool IsUnaryOp(Value op) {
     return (NOT <= op && op <= VOID) || op == ADD || op == SUB;
   }
@@ skipping 24 matching lines @@
  private:
   static const char* const name_[NUM_TOKENS];
   static const char* const string_[NUM_TOKENS];
   static const int8_t precedence_[NUM_TOKENS];
   static const char token_type[NUM_TOKENS];
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_TOKEN_H_