[Android WebView] Implement WebSettings.{get|set}LoadWithOverviewMode

content/renderer/render_view_impl.cc

Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 49a9921f130327751f1d0bde0ee2e1246294d49f..8731ff7b466e94f8bf4bca887eda1f66ddde969f 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2365,6 +2365,13 @@ void RenderViewImpl::UpdateTargetURL(const GURL& url,
   }
 }
 
+void RenderViewImpl::WebPreferencesUpdated(const WebPreferences& old_prefs) {

[jamesr, 2013/02/19 23:26:21]

I'd rather just do this inline in OnUpdateWebPreferences(), the function
indirection doesn't seem to buy much. Alternately, if this doesn't behave like
other WebPreferences in that it has extra state perhaps it should be managed
separately.

[mnaganov (inactive), 2013/02/20 10:36:49]

This setting resides in WebPreferences because it's used by ChromeClientImpl,
not by WebView itself. The reason we need to make a call to WebView is because
the latter doesn't reinitialize scale when reloading the same page.

In fact, a lot of WebKit settings require some actions to be done on changing
them, but this is hidden inside Settings.cpp in WebCore. However, this
particular setting isn't from WebCore, but rather from WebKit Chromium client,
where WebSettingsImpl doesn't have access to WebViewImpl and thus can't mimic
WebCore Settings' behaviour.

So I don't see a reason for making this a Renderer Preference, but I'm following
your advice on inlining the check inside WebPreferencesUpdated.

+  if (old_prefs.initialize_at_minimum_page_scale !=
+      webkit_preferences_.initialize_at_minimum_page_scale) {
+    webview()->resetScrollAndScaleState();
+  }
+}
+
 gfx::RectF RenderViewImpl::ClientRectToPhysicalWindowRect(
     const gfx::RectF& rect) const {
   gfx::RectF window_rect = rect;
@@ -5311,8 +5318,10 @@ void RenderViewImpl::OnDragSourceSystemDragEnded() {
 }
 
 void RenderViewImpl::OnUpdateWebPreferences(const WebPreferences& prefs) {
+  const WebPreferences old_preferences = webkit_preferences_;
   webkit_preferences_ = prefs;
   webkit_preferences_.Apply(webview());
+  WebPreferencesUpdated(old_preferences);
 }
 
 void RenderViewImpl::OnUpdateTimezone() {