[Android WebView] Implement WebSettings.{get|set}LoadWithOverviewMode

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 3309 matching lines @@
     document_state->set_load_type(DocumentState::RELOAD);
   else if (!params.state.empty())
     document_state->set_load_type(DocumentState::HISTORY_LOAD);
   else
     document_state->set_load_type(DocumentState::NORMAL_LOAD);
 
   document_state->set_referrer_policy(params.referrer.policy);
   document_state->set_is_overriding_user_agent(params.is_overriding_user_agent);
   document_state->set_must_reset_scroll_and_scale_state(
       params.navigation_type ==
           ViewMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL);

[jamesr, 2013/02/21 22:38:32]

if you just want to modify the behavior on page reload, it seems like perhaps
this is the line of code you want to be patching

[mnaganov (inactive), 2013/02/22 15:55:16]

Thanks for pointing this out! But at this point I don't have information,
whether the setting value has been flipped. And introducing a special flag for
that seems to be of a doubtful usefulness for a feature that is only used for
emulating legacy behaviour of Android WebView. 

   document_state->set_can_load_local_resources(params.can_load_local_resources);
 }
 
 NavigationState* RenderViewImpl::CreateNavigationStateFromPending() {
   const ViewMsg_Navigate_Params& params = *pending_navigation_params_.get();
   NavigationState* navigation_state = NULL;
 
   // A navigation resulting from loading a javascript URL should not be treated
   // as a browser initiated event.  Instead, we want it to look as if the page
   // initiated any load resulting from JS execution.
@@ skipping 1984 matching lines @@
     webview()->dragSourceEndedAt(client_point, screen_point, op);
   } else {
     webview()->dragSourceMovedTo(client_point, screen_point, op);
   }
 }
 
 void RenderViewImpl::OnDragSourceSystemDragEnded() {
   webview()->dragSourceSystemDragEnded();
 }
 
+
 void RenderViewImpl::OnUpdateWebPreferences(const WebPreferences& prefs) {
+  const bool old_initialize_at_minimum_page_scale =
+      webkit_preferences_.initialize_at_minimum_page_scale;
   webkit_preferences_ = prefs;
   webkit_preferences_.Apply(webview());
+  if (old_initialize_at_minimum_page_scale !=
+      webkit_preferences_.initialize_at_minimum_page_scale) {
+    webview()->resetScrollAndScaleState();
+  }
 }
 
 void RenderViewImpl::OnUpdateTimezone() {
   if (webview())
     NotifyTimezoneChange(webview()->mainFrame());
 }
 
 void RenderViewImpl::OnSetAltErrorPageURL(const GURL& url) {
   alternate_error_page_url_ = url;
 }
@@ skipping 1323 matching lines @@
   TransportDIB* dib = TransportDIB::CreateWithHandle(dib_handle);
   RenderProcess::current()->ReleaseTransportDIB(dib);
 }
 
 void RenderViewImpl::DidCommitCompositorFrame() {
   RenderWidget::DidCommitCompositorFrame();
   FOR_EACH_OBSERVER(RenderViewObserver, observers_, DidCommitCompositorFrame());
 }
 
 }  // namespace content